Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expense Tracking in the Workspace Chat #39239

Merged
merged 15 commits into from
Apr 8, 2024

Conversation

paultsimura
Copy link
Contributor

@paultsimura paultsimura commented Mar 29, 2024

Details

This PR enables tracking expenses within the Workspace money reports.

Fixed Issues

$ #38971
PROPOSAL: N/A

Tests

Same as QA

Offline tests

Same as QA

QA Steps

  1. Go to your own policy expense chat where you don't have an active expense report
  2. Click "+" -> Track expense -> proceed with amount of $10
  3. Verify a Report Preview was created with title "{user} spent: $10"
  4. Open the Expense report
  5. Verify the total shows $10
  6. Click "+" -> Request money -> proceed with $5
  7. Verify the total now shows a separation:
    • Total: $15
    • Out-of-pocket spend: $5
    • Company spend: $10
  8. Click "+" -> Track expense -> proceed with amount of $5
  9. Verify the total now shows a separation:
    • Total: $20
    • Out-of-pocket spend: $5
    • Company spend: $15
  10. Click "Submit"
  11. Click "Approve"
  12. Verify a message
  13. Verify the settlement button now says "Pay $5 ..."
  14. Click "Pay elsewhere"
  15. Verify it says "Paid $5 ..."

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android20.52.mp4
Android: mWeb Chrome
chrome20.45.mp4
iOS: Native
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-04-01.at.20.26.5220.28.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-04-01.at.20.37.5120.38.mp4
MacOS: Chrome / Safari
Screen.Recording.2024-04-01.at.19.46.3119.47.mp4
MacOS: Desktop
Screen.Recording.2024-04-01.at.19.57.2519.58.mp4

@paultsimura
Copy link
Contributor Author

I've created this draft PR to start tracking the existing issues that are blocking the PR, but are not directly related to it.

@paultsimura
Copy link
Contributor Author

First of all, the App is crashing because of the Shortcut feature – it doesn't support the TRACK_* actions.
I need to get copies for the Shortcut button for the following actions:

  • trackManual
  • trackScan
  • trackDistance
image

@thienlnam could you please help with adding the corresponding label or tagging relevant people?

@paultsimura
Copy link
Contributor Author

Another issue – the removal doesn't work as expected. It removes the action optimistically, but after a refresh, the action reappears as a skeleton, and the transaction thread exists, but with an empty transaction.

@shubham1206agra is it known from the times you implemented the self-dm tracking?

Screen.Recording.2024-03-29.at.14.20.2114.22.mp4

@shubham1206agra
Copy link
Contributor

Yes it's a known issue
@thienlnam is working on this

@paultsimura
Copy link
Contributor Author

A couple more things I'd like to clarify:

image

First – there is no visual difference between the tracking expense (1st) and the actual money request (2nd) – do we want to change it?


Second – I'd like to know more about the expected total separation.

  1. Do I understand correctly that adding a Tracking Expense inside an Expense Report should increase the Total and Company spend, but not the Out-of-pocket spend?
  2. When there are no other money requests, only a tracking one, it will look like this (showing only Total), are we ok with this?
image image

@shubham1206agra
Copy link
Contributor

First – there is no visual difference between the tracking expense (1st) and the actual money request (2nd) – do we want to change it?

No, as we don't have any such thing in docs. But let me summon @Expensify/design so that they can chime in.

@shubham1206agra
Copy link
Contributor

Do I understand correctly that adding a Tracking Expense inside an Expense Report should increase the Total and Company spend, but not the Out-of-pocket spend?

This is a non-reimbursable expense. That's why it will behave like this.

@shubham1206agra
Copy link
Contributor

When there are no other money requests, only a tracking one, it will look like this (showing only Total), are we ok with this?

Not sure. @thienlnam can confirm this.

@paultsimura
Copy link
Contributor Author

One more thing that bothers me is the Report Preview text.

Currently, if the total looks like this:
image

The preview will show plainly "Spent $total":
image

Is there any design for what we should show in such cases (when there are reimbursable and non-reimbursable requests combined)?

@shubham1206agra
Copy link
Contributor

Again @Expensify/design can help here.

@dannymcclain
Copy link
Contributor

Hmm, I'm really curious for the other designer's thoughts on these.

First – there is no visual difference between the tracking expense (1st) and the actual money request (2nd) – do we want to change it?

For this one, I could maybe see editing the Cash line or maybe just adding a dot separator and appending something there to make it more clear? I'm not sure.

Is there any design for what we should show in such cases (when there are reimbursable and non-reimbursable requests combined)?

This one has me kinda stumped. I don't know that we want to change the preview behavior or create a custom preview for tracked expenses, so I'm not sure if there's a good solution for this.

@Expensify/design any ideas?

@shawnborton
Copy link
Contributor

First – there is no visual difference between the tracking expense (1st) and the actual money request (2nd) – do we want to change it?

Correct - whether you track a personal expense or send someone a money request, they are both just expenses under the hood and they would look the same at the expense level.

Do I understand correctly that adding a Tracking Expense inside an Expense Report should increase the Total and Company spend, but not the Out-of-pocket spend?

I don't understand why we are handling it this way. If you add an expense to a report, it just increases the total. The "Company spend" vs "Out of pocket spend" is just a nicer way of saying "Is this expense reimburseable or not?"

Unless I am missing something. Did the GH issue or design doc specify otherwise?

When there are no other money requests, only a tracking one, it will look like this (showing only Total), are we ok with this?

Yes. We already have existing patterns for what expenses look like when they are added to a workspace, so we just follow what we currently have.

@thienlnam can you also chime in here? Seems like maybe there is some misunderstanding going on.

@paultsimura
Copy link
Contributor Author

The "Company spend" vs "Out of pocket spend" is just a nicer way of saying "Is this expense reimburseable or not?"

Yes, from what I understood.

@paultsimura
Copy link
Contributor Author

One more BE issue related to money request removal:

  1. Have both non- and reimbursable requests in one Money report
  2. Remove the reimbursable one
  3. Observe that for a moment, the optimistic total is correct
  4. When the DeleteMoneyRequest response comes, see that the total becomes 0
  5. After refreshing the page, see that the total is back to normal.

The DeleteMoneyRequest API returns the iouReport.total: 0 and iouReport.unheldTotal: 0 – this needs to be fixed.

Screen.Recording.2024-03-30.at.16.46.2716.47.mp4

@paultsimura paultsimura marked this pull request as ready for review March 30, 2024 22:01
@paultsimura paultsimura requested a review from a team as a code owner March 30, 2024 22:01
@melvin-bot melvin-bot bot removed the request for review from a team March 30, 2024 22:01
Copy link

melvin-bot bot commented Mar 30, 2024

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested a review from shubham1206agra March 30, 2024 22:01
@paultsimura
Copy link
Contributor Author

@shubham1206agra you can start the preliminary testing (just please be aware that the current main has the regular money request flow broken).
I will fill out the checklist by Monday.

@shubham1206agra
Copy link
Contributor

Screenshot 2024-04-01 at 5 43 08 PM

@paultsimura @Expensify/design Should we show paid sign to non-reimbursable request?

@shawnborton
Copy link
Contributor

Hmm did the user take any action to trigger that state? Like did the user mark the report as Paid? If so, then yes.

@shubham1206agra
Copy link
Contributor

Yes, I used Pay elsewhere on the report.

@paultsimura
Copy link
Contributor Author

@thienlnam this must be a single-transaction Expense Report.
The thing that's failing is the removal of Expense Report, which is not triggered when there are other money requests in it (in your video there are 3 of them)

@thienlnam
Copy link
Contributor

Ah gotcha, this seems to happen for regular requests as well - I will create an issue to track it

@paultsimura
Copy link
Contributor Author

Ah gotcha, this seems to happen for regular requests as well - I will create an issue to track it

Thanks, I will double check tomorrow if I can fix the skeleton bug without this BE fix

# Conflicts:
#	src/pages/home/report/ReportActionsView.tsx
@paultsimura
Copy link
Contributor Author

this seems to happen for regular requests as well

I couldn't reproduce for the regular ones 🤔

@paultsimura
Copy link
Contributor Author

I managed to localize the issue more:

  1. It comes from feat: Expense Tracking in the Workspace Chat #39239 (comment)@thienlnam should have a tracking issue for that – the IOU Report is not properly deleted when removing the only money request within it.
  2. The empty REPORTPREVIEW action reappears after the OpenReport API call, but the linked IOU Report is absent in Onyx.
  3. There are 2 scenarios from here:
    a. Click the empty preview, so the IOU Report gets loaded into Onyx – in this case, creating a new Tracking Expense works well
    b. Do not open the empty preview, so the empty IOU Report is still null – in this case, creating a new Tracking Expense causes the skeleton view.

An observation: the TrackExpense API response turns the empty IOU preview into a "deleted" empty action:
image

However, it doesn't re-link the new report preview action with the action that came before the deleted empty preview. As a result, this function, which builds the report actions list by linking them via previousReportActionID, returns a single report action, which causes the skeleton:

/**
* Returns the largest gapless range of reportActions including a the provided reportActionID, where a "gap" is defined as a reportAction's `previousReportActionID` not matching the previous reportAction in the sortedReportActions array.
* See unit tests for example of inputs and expected outputs.
* Note: sortedReportActions sorted in descending order
*/
function getContinuousReportActionChain(sortedReportActions: ReportAction[], id?: string): ReportAction[] {
let index;
if (id) {
index = sortedReportActions.findIndex((reportAction) => reportAction.reportActionID === id);
} else {
index = sortedReportActions.findIndex(
(reportAction) =>
reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD &&
reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE &&
!reportAction.isOptimisticAction,
);
}
if (index === -1) {
// if no non-pending action is found, that means all actions on the report are optimistic
// in this case, we'll assume the whole chain of reportActions is continuous and return it in its entirety
return id ? [] : sortedReportActions;
}
let startIndex = index;
let endIndex = index;
// Iterate forwards through the array, starting from endIndex. This loop checks the continuity of actions by:
// 1. Comparing the current item's previousReportActionID with the next item's reportActionID.
// This ensures that we are moving in a sequence of related actions from newer to older.
while (
(endIndex < sortedReportActions.length - 1 && sortedReportActions[endIndex].previousReportActionID === sortedReportActions[endIndex + 1].reportActionID) ||
!!sortedReportActions[endIndex + 1]?.whisperedToAccountIDs?.length ||
!!sortedReportActions[endIndex]?.whisperedToAccountIDs?.length ||
sortedReportActions[endIndex]?.actionName === CONST.REPORT.ACTIONS.TYPE.ROOMCHANGELOG.INVITE_TO_ROOM ||
sortedReportActions[endIndex + 1]?.actionName === CONST.REPORT.ACTIONS.TYPE.CLOSED ||
sortedReportActions[endIndex + 1]?.actionName === CONST.REPORT.ACTIONS.TYPE.CREATED
) {
endIndex++;
}
// Iterate backwards through the sortedReportActions, starting from startIndex. This loop has two main checks:
// 1. It compares the current item's reportActionID with the previous item's previousReportActionID.
// This is to ensure continuity in a sequence of actions.
// 2. If the first condition fails, it then checks if the previous item has a pendingAction of 'add'.
// This additional check is to include recently sent messages that might not yet be part of the established sequence.
while (
(startIndex > 0 && sortedReportActions[startIndex].reportActionID === sortedReportActions[startIndex - 1].previousReportActionID) ||
sortedReportActions[startIndex - 1]?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD ||
sortedReportActions[startIndex - 1]?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE ||
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
sortedReportActions[startIndex - 1]?.isOptimisticAction ||
sortedReportActions[startIndex - 1]?.actionName === CONST.REPORT.ACTIONS.TYPE.ROOMCHANGELOG.INVITE_TO_ROOM
) {
startIndex--;
}
return sortedReportActions.slice(startIndex, endIndex + 1);
}

My suggestion is to fix the Expense Report removal on the BE side rather than find workarounds.

@thienlnam
Copy link
Contributor

Yeah I agree we shouldn't find a workaround from the FE side. However, it doesn't seem like a blocker so we can proceed here and then once the BE is fixed it should just work

@paultsimura
Copy link
Contributor Author

@shubham1206agra the longer it takes to review & merge this PR – the more conflicts arise (new ones each day). As per the last comment, this PR should be ready for the final testing

@shubham1206agra
Copy link
Contributor

shubham1206agra commented Apr 8, 2024

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
Screen.Recording.2024-04-08.at.6.38.56.PM.mp4
MacOS: Chrome / Safari
Screen.Recording.2024-04-08.at.6.12.58.PM.mp4
MacOS: Desktop

@shubham1206agra
Copy link
Contributor

Screenshot 2024-04-08 at 6 31 29 PM

@thienlnam The track is taking longer to fetch from BE. (Little confused here tbh)
cc @paultsimura

Copy link
Contributor

@shubham1206agra shubham1206agra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melvin-bot melvin-bot bot requested a review from thienlnam April 8, 2024 13:33
# Conflicts:
#	src/libs/ReportUtils.ts
Copy link
Contributor

@thienlnam thienlnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thanks!

@thienlnam thienlnam merged commit 6ec5811 into Expensify:main Apr 8, 2024
14 of 15 checks passed
@thienlnam
Copy link
Contributor

Perf tests known to be failing

@OSBotify
Copy link
Contributor

OSBotify commented Apr 8, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.62-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

1 similar comment
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.62-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.62-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@MonilBhavsar
Copy link
Contributor

We seem to have a regression here #40067. If anyone can please take a look cc @paultsimura @shubham1206agra @thienlnam

@paultsimura
Copy link
Contributor Author

I'm on it

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.62-17 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants