fix: 31101 Eye icon to show password on password protected PDF file is not working #31176

tienifr · 2023-11-10T11:51:30Z

Details

Fixed Issues

$ #31101
PROPOSAL: #31101 (comment)

Tests

Tap on the password protected PDF preview on the chat.
Tap on "enter the password".
Type some characters.
Tap on the eye icon to reveal the password.
The password should be revealed and visible to the user.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Tap on the password protected PDF preview on the chat.
Tap on "enter the password".
Type some characters.
Tap on the eye icon to reveal the password.
The password should be revealed and visible to the user.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2023-11-10.at.18.48.47.mov

MacOS: Desktop

…s not working

melvin-bot · 2023-11-10T11:51:59Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tienifr · 2023-11-10T12:33:43Z

RNW issue is up here: necolas/react-native-web#2606

mananjadhav · 2023-11-10T22:56:46Z

@tienifr The patch isn't getting installed for me. This the error I get when I did a fresh npm i


**ERROR** Failed to apply patch for package react-native-web

  This happened because the patch file patches/react-native-web+0.19.9+003+fix-pointer-events.patch could not be parsed.

and then when I tried to run this specific patch using patch -p1 -i patches/react-native-web+0.19.9+003+fix-pointer-events.patch.

patching file 'node_modules/react-native-web/src/exports/StyleSheet/compiler/index.js'
patch: **** malformed patch at line 21:

Can you confirm if it works fine at your end?

mananjadhav · 2023-11-10T23:04:11Z

This is the patch that I generated and works fine on my local.

diff --git a/node_modules/react-native-web/src/exports/StyleSheet/compiler/index.js b/node_modules/react-native-web/src/exports/StyleSheet/compiler/index.js
index 639f532..7445b76 100644
--- a/node_modules/react-native-web/src/exports/StyleSheet/compiler/index.js
+++ b/node_modules/react-native-web/src/exports/StyleSheet/compiler/index.js
@@ -385,13 +385,13 @@ function createAtomicRules(identifier: string, property, value): Rules {
         finalValue = 'auto!important';
         if (value === 'box-only') {
           const block = createDeclarationBlock({ pointerEvents: 'none' });
-          rules.push(`${selector}>*${block}`);
+          rules.push(`${selector} *${block}`);
         }
       } else if (value === 'none' || value === 'box-none') {
         finalValue = 'none!important';
         if (value === 'box-none') {
           const block = createDeclarationBlock({ pointerEvents: 'auto' });
-          rules.push(`${selector}>*${block}`);
+          rules.push(`${selector} *${block}`);
         }
       }
       const block = createDeclarationBlock({ pointerEvents: finalValue });

mananjadhav · 2023-11-11T17:46:30Z

and even after applying the patch it isn't working for me. I can see your videos it is working fine, but something that I am missing out?

eye-pdf-icon.mov

situchan

update file name to +004
+003 already exists

tienifr · 2023-11-13T03:41:26Z

@situchan @mananjadhav Thanks for your comment. I just updated the filename

mananjadhav · 2023-11-13T19:23:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-pdf-eye-con.mov

Android: mWeb Chrome

mweb-chrome-pdf-eye-icon.mov

iOS: Native

ios-pdf-eye-icon.mov

iOS: mWeb Safari

mweb-safari-pdf-eye-icon.mov

MacOS: Chrome / Safari

web-pdf-eye-icon.mov

MacOS: Desktop

desktop-pdf-eye-icon.mov

danieldoglas · 2023-11-14T15:49:50Z

@situchan can you please re-do the author checklist? It's failing the check for some reason, so please copy it from a blank PR and refill it to guarantee we're checking all the items and none were deleted by mistake

situchan · 2023-11-14T15:50:46Z

@situchan can you please re-do the author checklist? It's failing the check for some reason, so please copy it from a blank PR and refill it to guarantee we're checking all the items and none were deleted by mistake

you meant to tag @tienifr? 😄

danieldoglas · 2023-11-14T18:47:22Z

yes, sorry about that hah

tienifr · 2023-11-15T03:34:31Z

@danieldoglas Thanks, It's fixed

OSBotify · 2023-11-15T14:54:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-20T13:41:07Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.0-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

mananjadhav · 2024-02-19T18:47:21Z

We had to rollback the patch because it caused this issue.

fix: 31101 Eye icon to show password on password protected PDF file i…

ba75ff9

…s not working

tienifr marked this pull request as ready for review November 10, 2023 11:51

tienifr requested a review from a team as a code owner November 10, 2023 11:51

melvin-bot bot requested review from mananjadhav and removed request for a team November 10, 2023 11:51

situchan suggested changes Nov 12, 2023

View reviewed changes

tienifr added 2 commits November 13, 2023 10:28

Merge branch 'main' into fix/31101

9a4d943

rename patch file

f34c1e2

mananjadhav approved these changes Nov 13, 2023

View reviewed changes

melvin-bot bot requested a review from danieldoglas November 13, 2023 19:24

danieldoglas approved these changes Nov 14, 2023

View reviewed changes

Merge branch 'main' into fix/31101

8423ebb

danieldoglas merged commit 0151ae3 into Expensify:main Nov 15, 2023
7 checks passed

OSBotify mentioned this pull request Nov 16, 2023

Deploy Checklist: New Expensify 2023-11-15 #31404

Closed

37 tasks

melvin-bot bot mentioned this pull request Nov 20, 2023

[HOLD for payment 2023-11-27] [$500] PDF preview - Eye icon to show password on password protected PDF file is not working #31101

Closed

6 tasks

Beamanator mentioned this pull request Dec 6, 2023

Tracker to follow up with react-native-web patches #32544

Closed

bernhardoj mentioned this pull request Jan 4, 2024

[HOLD for payment 2024-02-20] [$500] Copy icon - Clicking copy icon on an offline deleted message doesn't copy the message #33893

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: 31101 Eye icon to show password on password protected PDF file is not working #31176

fix: 31101 Eye icon to show password on password protected PDF file is not working #31176

tienifr commented Nov 10, 2023 •

edited

Loading

melvin-bot bot commented Nov 10, 2023

tienifr commented Nov 10, 2023

mananjadhav commented Nov 10, 2023 •

edited

Loading

mananjadhav commented Nov 10, 2023

mananjadhav commented Nov 11, 2023 •

edited

Loading

situchan left a comment

tienifr commented Nov 13, 2023 •

edited

Loading

mananjadhav commented Nov 13, 2023

danieldoglas commented Nov 14, 2023

situchan commented Nov 14, 2023

danieldoglas commented Nov 14, 2023

tienifr commented Nov 15, 2023

OSBotify commented Nov 15, 2023

OSBotify commented Nov 20, 2023

mananjadhav commented Feb 19, 2024

fix: 31101 Eye icon to show password on password protected PDF file is not working #31176

fix: 31101 Eye icon to show password on password protected PDF file is not working #31176

Conversation

tienifr commented Nov 10, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 10, 2023

tienifr commented Nov 10, 2023

mananjadhav commented Nov 10, 2023 • edited Loading

mananjadhav commented Nov 10, 2023

mananjadhav commented Nov 11, 2023 • edited Loading

situchan left a comment

Choose a reason for hiding this comment

tienifr commented Nov 13, 2023 • edited Loading

mananjadhav commented Nov 13, 2023

Reviewer Checklist

Screenshots/Videos

danieldoglas commented Nov 14, 2023

situchan commented Nov 14, 2023

danieldoglas commented Nov 14, 2023

tienifr commented Nov 15, 2023

OSBotify commented Nov 15, 2023

OSBotify commented Nov 20, 2023

mananjadhav commented Feb 19, 2024

tienifr commented Nov 10, 2023 •

edited

Loading

mananjadhav commented Nov 10, 2023 •

edited

Loading

mananjadhav commented Nov 11, 2023 •

edited

Loading

tienifr commented Nov 13, 2023 •

edited

Loading