[$250] Thread is not loading

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: need reproduction
Reproducible in production?: need reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @danielrvidal
Slack conversation (hyperlinked to channel name): Expensify-quality

Action Performed:

1. Click on a thread https://new.expensify.com/r/1634198864969112

Expected Result:

Thread should open

Actual Result:

Not opening the thread and got a spinner
(it worked before I could turn on loggin.)

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

2024-11-19_11-21-01.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021863768282323086174
• Upwork Job ID: 1863768282323086174
• Last Price Increase: 2024-12-03

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MariaHCD (AutoAssignerNewDotQuality)

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[melvin-bot]

@MariaHCD, @adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MariaHCD]

I haven't been able to reproduce this bug thus far 🤔

But let's follow the steps in this SO: https://stackoverflowteams.com/c/expensify/questions/16989

And if we aren't able to reproduce this ourselves, maybe @danielrvidal can try again and if it happens, we can fetch the logs to see if this is a backend issue.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021863768282323086174

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[adelekennedy]

@ntdiary can you give reproducing this a whirl?

[ntdiary]

@ntdiary can you give reproducing this a whirl?

@adelekennedy, I can't reproduce it. Maybe it's because this is an private chat?

[muttmuure]

This was likely a network issue.

[muttmuure]

We can either:

• Investigate why the network connection failure was not surfaced in the skeleton
• Close this out

[bhaggat]

I tried to reproduce it, but could not do it, there must be a specific use case that needs to be debugged by checking all the possibilities.

Possibilities:-

• Something is broken from the backend, it can be failing or sending the wrong structured data
• State is not updating for specific use cases after getting the response
• API call is not triggering for some reason again, can be state-related issue or some condition is blocking the call
• Sometimes Issue can be because of Structure changed in backend with new version, So it is possible that this is old data and was not patched during updating with new

Way to debug:-

• Check if the API request is triggering or not, if not go in that direction
• Check if the response is in the correct structure by checking with other chats, if not fix that issue
• Check if API request is triggering but it is failing check the issue on the backend by adding logs or comparing it with other similar requests

[melvin-bot]

📣 @bhaggat! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[bhaggat]

Contributor details
Your Expensify account email: in [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01b7b8ac0c1016849d

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

@ntdiary, @MariaHCD, @adelekennedy Eep! 4 days overdue now. Issues have feelings too...

[MariaHCD]

Investigate why the network connection failure was not surfaced in the skeleton

For this, is there a way we can simulate a network connection failure on the frontend? @ntdiary 🤔

[ntdiary]

For this, is there a way we can simulate a network connection failure on the frontend? @ntdiary 🤔

@MariaHCD, For the Chrome, we can open the Developer Tools, switch to the Network tab, and select a predefined 4G or 3G or Offline profile. Also, we can use the Add... to customize any download speed. :)

network.mp4

[ntdiary]

Investigate why the network connection failure was not surfaced in the skeleton

@muttmuure, are you referring to the "You appear to be offline" message not being displayed?

When we open a thread that hasn’t yet been loaded into the local Onyx, app won't show the main composer, so this message wouldn’t be displayed either, like this:

related code:

App/src/pages/home/ReportScreen.tsx

Lines 857 to 858 in 8981081

	{isCurrentReportLoadedFromOnyx ? (
	<ReportFooter

From the dev tools logs in the OP, it seems their network was changed when opening the thread (i.e., ERR_NETWORK_CHANGED), and then the network was interrupted for a while (i.e., ERR_CONNECTION_REFUSED). As a result, the thread couldn’t be opened, and the offline message wasn’t displayed either.

I’m not sure if they were using a proxy or firewall, but I think this should be a very edge case. Additionally, from the original video, it seems their network was reconnected later, allowing them to open the thread normally. :)

[melvin-bot]

@ntdiary @MariaHCD @adelekennedy this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[MariaHCD]

Good points, @ntdiary !

For end users:

• ERR_CONNECTION_REFUSED indicates a problem with the server or the client's network.
• ERR_NETWORK_CHANGED suggests the end user's connection changed (e.g., switching between networks).

So this does seem like it's an edge case. I'm not super sure there's anything that we can action here 🤔

Thoughts, @adelekennedy @muttmuure?

[melvin-bot]

@ntdiary, @MariaHCD, @adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@ntdiary, @MariaHCD, @adelekennedy Still overdue 6 days?! Let's take care of this!

[MariaHCD]

@adelekennedy could you review the comments here and here, and let us know what you think?

[melvin-bot]

@ntdiary, @MariaHCD, @adelekennedy Huh... This is 4 days overdue. Who can take care of this?

[ntdiary]

@adelekennedy could you review the comments here and here, and let us know what you think?

waiting for more input, then if this issue still can't be reproduced, maybe we can just close it. :)

[adelekennedy]

Agreed I think we can likely close this one!

[melvin-bot]

@ntdiary @MariaHCD @adelekennedy this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

@ntdiary, @MariaHCD, @adelekennedy Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@ntdiary, @MariaHCD, @adelekennedy Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@ntdiary, @MariaHCD, @adelekennedy Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[MariaHCD]

Looks like we agree that this can be closed since there's nothing we can action here. Closing for now!