-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-12-20] [$250] Something went wrong error message displayed upon opening the laptop/app after being inactive for a few hours #52312
Comments
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989 |
Triggered auto assignment to @marcaaron ( |
Triggered auto assignment to @RachCHopkins ( |
I leave my laptop running with newdot open every night and weekend, and I have never had this happen. @m-natarajan it looks like your team were unable to reproduce this? @marcaaron do you know what could cause such a thing? Seems to me it's likely unrelated to just wandering off and leaving the laptop open. |
Let's make this external and see if anyone has any ideas? I think this is the relevant part of the logs. It was a
|
The only thing I changed recently is to make the map load lazily. What I can see that could happen is the app is loaded, then we make an update and the js files change since they use a content hash in the name, then the old version of the app tries to load a chunk that no longer exists. If that is the case we could either try to catch these bundle load errors and do a full app reload or have some way to keep old versions of the files available once we deploy an update. |
That solution sounds good to me. I'd think this should be fairly rare occurrence in any case.
This sounds better, but I'm unsure what it would take and it sounds easier to do the first idea. |
I think so too, I have pretty low availability in the next few weeks if anyone wants to pick this up, otherwise I can have a look as soon as I can. |
@RachCHopkins, @marcaaron Whoops! This issue is 2 days overdue. Let's get this updated quick! |
I'm going to make this External since it sounds like there is a more or less rough idea for how to address and we just need someone to step up and do it. |
Job added to Upwork: https://www.upwork.com/jobs/~021858612609610396238 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 ( |
Hi, I'm Nicolay from Callstack - expert contributor group - and I would like to work on this issue. |
@marcaaron, can we focus on the refresh bug now here, and keep the logout bug #52312 (comment) to see if anyone still able to reproduce? |
Yes, let's please focus on that one thing. I think the refresh changes mean there is no "log out" happening, but they seem to have different root causes. |
@narefyev91 please let me know when PR ready. |
yeah currently working on it |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.75-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-12-20. 🎊 For reference, here are some details about the assignees on this issue:
|
@ahmedGaber93 @RachCHopkins @ahmedGaber93 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
@ahmedGaber93 please can you complete the checklist before payment is due? Thanks! |
BugZero Checklist:
Bug classificationSource of bug:
Where bug was reported:
Who reported the bug:
I don't think we need a regression test here because this issue occurs randomly and hard to reproduce. |
Payment Summary:
Upwork job here |
Argh, sorry @ahmedGaber93 your offer expired literally yesterday despite being due for payment today. Just sent you a new one. |
@RachCHopkins, please cancel the upwork offer, I will get paid in NewDot. Thanks! |
Thanks @ahmedGaber93 I have updated the payment summary to reflect that! |
Contributor is to be paid via NewDot, the contract has been withdrawn, and the Upwork post has been closed. |
$250 approved for @ahmedGaber93 |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation (hyperlinked to channel name): ts_external_expensify_quality
Action Performed:
Expected Result:
User able to continue to use the app after being inactive for few hours
Actual Result:
Uh-oh, Something went wrong error
message displayed and on clicking refresh first time did not solve the issue and secondtime signin page displayedWorkaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @RachCHopkinsThe text was updated successfully, but these errors were encountered: