-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-10-17] [$250] mWeb - Continue button does not work in onboarding modal #50299
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @dylanexpensify ( |
Triggered auto assignment to @flodnv ( |
I'll assign myself to this one. |
Job added to Upwork: https://www.upwork.com/jobs/~021843045414173678587 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 ( |
Will see if a contributor can fix this by tomorrow, since I need to leave now (it's Sunday here). Hopefully we can get a proposal/PR early |
Edited by proposal-police: This proposal was edited at 2024-10-07 13:16:07 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Continue button does not work in onboarding modal What is the root cause of that problem?Redirect links produced by staging.expensify.com in case differs and does not contain Generated link on android chromehttps://staging.new.expensify.com/transition?accountID=18441429&email=sachin.expensify.test%2B1158%40gmail.com&shortLivedAuthToken=200EFA12DEC3685D5C26A2EA6B9B2F527436E9A5EBEB258821F4F5AE8557C444BB6A9E233BE5B3F815F9D830439BEF29E0E8CEC6EDA649E0149674AD79B62BA2D804B836C772813432EFC2241F2F1F8133B457224530877533B53FA5F260EB12FBCD3C68FB3033FCB556B8032B0504476481BDA52B1BF9C1F002F696515FB979AB3CD6296A58F52ED9E40C3632834E60EEB610E9900D60E417FCB38F3448DCB022AFBDD9CC0FAA9A5F112F029A39BD64987A1A386915B631F35571C73544B2A6851715650DB05AAABB48D98BC6C235C909AB3FB9689661C00A4966BB5649E6CFE78DDAA683119773401E3BEA9ACE384C313FE2110F01C377A8BC0B052BA488F64093A7275763BB5BE9C1A89D8B8798D3A991AEF6764A4C013774F8893A125170F9EF8CC566BD6F7BF77096360FBB5A134CF5DA2F947FA54CE00BE7F953F2477F&encryptedAuthToken=oWenOigsc0oJgO%2BTiY3ppHIPT7E3Au3Wnj3rM6t0e3X25d6KnMZb7b6h3IqDChdqnMuLtccXFVa4x278xCrDTl%2F%2F8FwuOvsvYVAVyHe%2FruRm6Z205eJuqYsS4AMJjGGh%2F3yneGPa3JLKmojztgZ1PxKFsaTFNufmJEXVegHLD3WWES1JQDVRneuu%2Bv0tpfUsr0RMpmDn71pZRzr1qMotX8u4zhbDGcSRAXuxbnptW0F1Hhzf%2BwfffVUJ9qwUT%2FrOKfzGGdD0rBjHHfeVs5w9gjvk7J5%2FX%2BR9wHLGjE4cvYvElnIAyXzMT4Hlklv%2F76PBBJTkyU%2F3UMIlivfKKtBMrGrfYAvJiEiYiryBxdTB%2FEVxz1txAg7SYV4meXOW5RElfcqj7pdRksq0JPd0BJsOH1bwCMjgw7xMdX7zIlieSEFTKuR3mWaK3zRk719foWB2ABW6JCj7OBPJJ5x%2FQ9FQEB%2BCJjVqz%2FDQRrVcN6%2BDWDIjsOAri85guzM3jLyJ18o6jnWDMHeYP2kG0Df6OAvfoAXDSyTt7QHU9x2YXzSpXV9mqngRkPxCZnYkkbZ6Kj4hmdRshXVnUHJ%2Fl%2BVoZg1ME7yp%2BLDmUSICXKoCTn%2BR%2F0E4I6lmhff3ABaf%2BlX6Y382cT86m%2F0y1uJYZFuogUF%2FntapTyQkuC%2BMMK%2BEq27gGjQbodnjasDVHp3%2Bs%2ByoLfBZUUIC%2BoWpYGYiZyPDxxHAewLJ%2Btdsc6O9P0V1r79x6TdeeIylRVvJ53rDyq3wLsWB5uCHUAsffof40B0Soxa59QiZKcsptExUhB9oTn9WktScSYDiTvk9%2FXAwoWdUN5U6wDZmrC6U8lVHv135IuaLhmeKfl%2Bf%2Bg5EAw0zBTV7H6EZrNKnKfmQfzfbomEt6rLmnSKGpbVZq4pqNy1B3AE9C5Qp67dCjzFfALhSOgQIL%2FI%3D&exitTo=%2FAnd here we use url to fetch App/src/libs/Navigation/AppNavigator/AuthScreens.tsx Lines 277 to 287 in 69162d2
Due which onboardingPurposeSelected here is undefined and hence continue button is not functional.
What changes do you think we should make in order to solve the problem?
let signupQualifier = onboardingValues?.signupQualifier;
if (signupQualifier === CONST.ONBOARDING_SIGNUP_QUALIFIERS.INDIVIDUAL) {
Welcome.setOnboardingCustomChoices([CONST.ONBOARDING_CHOICES.PERSONAL_SPEND, CONST.ONBOARDING_CHOICES.EMPLOYER, CONST.ONBOARDING_CHOICES.CHAT_SPLIT]);
}
if (signupQualifier === CONST.ONBOARDING_SIGNUP_QUALIFIERS.VSB) {
Welcome.setOnboardingPurposeSelected(CONST.ONBOARDING_CHOICES.MANAGE_TEAM);
}
Note this way we eliminate other possible scenarios where same problem might occur due to use of url. What alternative solutions did you explore? (Optional)Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job. |
@carlosmiceli if you are in hurry you could check my proposal right now, I would raise a quick pr. |
@ChavdaSachin Sure, can you send a video please of it working properly before? |
Edited by proposal-police: This proposal was edited at 2024-10-07 16:56:24 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Continue button does not work. What is the root cause of that problem?
but because
What changes do you think we should make in order to solve the problem?
App/src/libs/Navigation/AppNavigator/AuthScreens.tsx Lines 281 to 286 in 6d8e739
we can make use of onboardingValues data: App/src/libs/actions/Welcome/OnboardingFlow.ts Lines 35 to 36 in 6d8e739
which we use in the getOnboardingInitialPath - this function works properly.
What alternative solutions did you explore? (Optional) |
I mistakenly deleted the last branch, New PR here @allgandalf |
@carlosmiceli I approved the PR yesterday, you can proceed with the merge there |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
Note ^ False Flag, I reverted our PR and tested it out, but the issue still occurs, details here , so not a regression from our end |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.47-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-10-17. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Tomorrow! |
Regression Test Proposal
Verify that: Continue button works and the onboarding modal navigates to the next page. Do we agree 👍 or 👎 |
Hey, this is ready for payment tomorrow, my upwork is: https://www.upwork.com/freelancers/~012449dd63a43050f7 |
@twilight294 looks like that link says profile no longer available |
sorry, updated the comment please check |
Ah thanks @twilight294! Sent offer! |
Accepted!! |
Done! |
@IuliiaHerets I am interested if you know what the most efficient issues to resolve, receive payment for likely are or have some organisation around this presently? I would like to contribute, a recent issue I studied that should have taken a few days to resolve, receive payment for spanned over one month time, the solution hasn't been verified & payments haven't been issued. I am interested in helping achieve more efficient resolutions for the remaining issues. I was suggested to discuss this in Slack, however I am not using Slack right this moment so will try there later. |
📣 @llvee! 📣
|
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: v9.0.45-2
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #47619
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
Continue button works and the onboarding modal navigates to the next page.
Actual Result:
Continue button does not work.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6625716_1728155256806.video_2024-10-05_02-08-42.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @dylanexpensifyThe text was updated successfully, but these errors were encountered: