[$250] RHN throws error if tags are deleted by admin while member is selecting. #48822

carlosmiceli · 2024-09-09T19:49:43Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

**Version Number:v9.0.30-19
**Reproducible in staging?:Y
**Reproducible in production?:Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
**Issue reported by:Carlos Miceli
Slack conversation:

Action Performed:

Logged into NewDot as the admin of a workspace in one window and a member in another.
Go to workspace settings as admin.
Go to the tags section
Make sure there are tags on the workspaces
As a member, open a report's tags in that workspace.
As an admin, delete all of the tags.

Expected Result:

There should be an "there are no tags yet" message.

Actual Result:

Workspace member sees an error view in the RHN instead.

Workaround:

Unknown.

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

tags.error.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021833231500737320464
Upwork Job ID: 1833231500737320464
Last Price Increase: 2024-09-16
Automatic offers:

FitseTLT | Contributor | 103987322

Issue Owner

Current Issue Owner: @parasharrajat

melvin-bot · 2024-09-09T19:49:52Z

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot · 2024-09-09T19:50:26Z

Job added to Upwork: https://www.upwork.com/jobs/~021833231500737320464

melvin-bot · 2024-09-09T19:50:30Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

FitseTLT · 2024-09-09T19:56:01Z

Edited by proposal-police: This proposal was edited at 2024-09-09 19:59:01 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

RHN throws error if tags are deleted by admin while member is selecting.

What is the root cause of that problem?

We show not found page when there are non enabled options here

App/src/pages/iou/request/step/IOURequestStepTag.tsx

Lines 80 to 81 in 1b479b0

    
           const shouldShowTag = ReportUtils.isReportInGroupPolicy(report) && (transactionTag || OptionsListUtils.hasEnabledTags(policyTagLists));

What changes do you think we should make in order to solve the problem?

We should implement empty state component as we did for category step page here

App/src/pages/iou/request/step/IOURequestStepCategory.tsx

Lines 171 to 174 in 1b479b0

    
           {shouldShowEmptyState && ( 
        
               <View style={[styles.flex1]}> 
        
                   <WorkspaceEmptyStateSection 
        
                       shouldStyleAsCard={false}

and display the empty section when shouldShowTag is false but we should remove !shouldShowTag condition from shouldShowNotFoundPage

const isLoading = !isOffline && policyTags === undefined;
const shouldShowEmptyState = !isLoading && !shouldShowTag;

(We might display not found page for non isReportInGroupPolicy instead of empty section as it might make more sense, we can apply the same change in category page too)
and display tag picker only when !shouldShowEmptyState && !isLoading and show loading indicator when isLoading
We should also use a new emptyTag title and subtitle copy

We should also set up edit tag button equivalent to edit category button (with the respective copy text and route to navigate to) here

App/src/pages/iou/request/step/IOURequestStepCategory.tsx

Lines 180 to 197 in 1b479b0

    
           {PolicyUtils.isPolicyAdmin(policy) && ( 
        
               <FixedFooter style={[styles.mtAuto, styles.pt5]}> 
        
                   <Button 
        
                       large 
        
                       success 
        
                       style={[styles.w100]} 
        
                       onPress={() => 
        
                           Navigation.navigate( 
        
                               ROUTES.SETTINGS_CATEGORIES_ROOT.getRoute( 
        
                                   policy?.id ?? '-1', 
        
                                   ROUTES.MONEY_REQUEST_STEP_CATEGORY.getRoute(action, iouType, transactionID, report?.reportID ?? '-1', backTo, reportActionID), 
        
                               ), 
        
                           ) 
        
                       } 
        
                       text={translate('workspace.categories.editCategories')} 
        
                       pressOnEnter 
        
                   /> 
        
               </FixedFooter>

The button will appear if the user is an admin

To allow the user to easily create tags and navigate back to money request flow, we can create a similar page to SETTINGS_CATEGORIES_ROOT with the WorkspaceTagsPage component (as we did for category by linking the same WorkspaceCategoriesPage in MoneyRequestModalStackNavigator here )
We will add tag root screen to SCREENS.RIGHT_MODAL.MONEY_REQUEST and link it to a route like settings/:policyID/tags and add the screen in MoneyRequestModalStackNavigator (WorkspaceTagsPage )
We will pass MONEY_REQUEST_STEP_TAG route to backTo to allow the user to come back to the money request tag edit flow ROUTES.MONEY_REQUEST_STEP_TAG

What alternative solutions did you explore? (Optional)

cretadn22 · 2024-09-10T03:45:58Z

I provided a simple and correct proposal

Proposal

Please re-state the problem that we are trying to solve in this issue.

RHN throws error if tags are deleted by admin while member is selecting

What is the root cause of that problem?

We haven't added Empty View to IOURequestStepTag

What changes do you think we should make in order to solve the problem?

Idea: We should show the empty view with the Edit button exclusively for admins, following the same approach we used for the category page

App/src/pages/iou/request/step/IOURequestStepCategory.tsx

Lines 171 to 199 in 968b610

    
           {shouldShowEmptyState && ( 
        
               <View style={[styles.flex1]}> 
        
                   <WorkspaceEmptyStateSection 
        
                       shouldStyleAsCard={false} 
        
                       icon={Illustrations.EmptyStateExpenses} 
        
                       title={translate('workspace.categories.emptyCategories.title')} 
        
                       subtitle={translate('workspace.categories.emptyCategories.subtitle')} 
        
                       containerStyle={[styles.flex1, styles.justifyContentCenter]} 
        
                   /> 
        
                   {PolicyUtils.isPolicyAdmin(policy) && ( 
        
                       <FixedFooter style={[styles.mtAuto, styles.pt5]}> 
        
                           <Button 
        
                               large 
        
                               success 
        
                               style={[styles.w100]} 
        
                               onPress={() => 
        
                                   Navigation.navigate( 
        
                                       ROUTES.SETTINGS_CATEGORIES_ROOT.getRoute( 
        
                                           policy?.id ?? '-1', 
        
                                           ROUTES.MONEY_REQUEST_STEP_CATEGORY.getRoute(action, iouType, transactionID, report?.reportID ?? '-1', backTo, reportActionID), 
        
                                       ), 
        
                                   ) 
        
                               } 
        
                               text={translate('workspace.categories.editCategories')} 
        
                               pressOnEnter 
        
                           /> 
        
                       </FixedFooter> 
        
                   )} 
        
               </View>

Note: In IOURequestStepTag, the isLoading variable is unnecessary because we don't fetchData as we do in IOURequestStepCategory

Step to Implement:

Eliminate the shouldShowTag condition from the shouldShowNotFoundPage
Incorporate the following code into IOURequestStepTagStep

             {!shouldShowTag && (
                <View style={[styles.flex1]}>
                    <WorkspaceEmptyStateSection
                        ......
                    />
                    {PolicyUtils.isPolicyAdmin(policy) && (
                        <FixedFooter style={[styles.mtAuto, styles.pt5]}>
                           .....
                        </FixedFooter>
                    )}
                </View>
            )}
            {shouldShowTag && (
                Current Code
            )}

What alternative solutions did you explore? (Optional)

FitseTLT · 2024-09-10T09:42:29Z

Sorry forgot to notify Updated

But note that my last update is hours before the other proposal above

parasharrajat · 2024-09-10T10:35:55Z

Ok. thanks everyone for the proposal and suggestions. I am inclined to implement a similar page like category selection.

@FitseTLT Looks like you are suggesting a couple more changes and some of them are enhancements.

Could you please structure your proposal in parts and clean it a bit?

cretadn22 · 2024-09-10T14:19:50Z

@parasharrajat How about my proposal?

FitseTLT · 2024-09-10T14:34:40Z

Ok. thanks everyone for the proposal and suggestions. I am inclined to implement a similar page like category selection.

@FitseTLT Looks like you are suggesting a couple more changes and some of them are enhancements.

Could you please structure your proposal in parts and clean it a bit?

@parasharrajat I have organized my proposal as per your request 👍

parasharrajat · 2024-09-10T14:52:03Z

@cretadn22 I will review that in sometime.

parasharrajat · 2024-09-10T21:44:54Z

@FitseTLT's proposal looks good to me. @cretadn22 I don't see any differences in the approach. Your proposal looks identical to @FitseTLT.

🎀 👀 🎀 C+ reviewed

melvin-bot · 2024-09-10T21:45:04Z

Current assignee @carlosmiceli is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

melvin-bot · 2024-09-16T16:00:06Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot · 2024-09-16T16:41:03Z

📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

carlosmiceli · 2024-09-16T16:41:10Z

Sorry to miss this, assigned to @FitseTLT !

FitseTLT · 2024-09-18T19:16:53Z

@carlosmiceli
We already have a copy for Edit tag Editar etiqueta but I need the plural form for the button text Edit tags and Google translate is suggesting Editar etiquetas Can u confirm?

carlosmiceli · 2024-09-18T19:17:48Z

@FitseTLT That's correct!

abekkala · 2024-10-11T14:25:54Z

PAYMENT SUMMARY OCT 11

Fix: @FitseTLT [$250] OFFER
PR Review: @parasharrajat [$250] payment via NewDot

abekkala · 2024-10-11T14:26:48Z

@FitseTLT payment sent and contract ended - thank you! 🎉

abekkala · 2024-10-11T14:28:53Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
[@parasharrajat] Determine if we should create a regression test for this bug.
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

parasharrajat · 2024-10-13T10:16:28Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: New feature
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: New Feature
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not needed
[@parasharrajat] Determine if we should create a regression test for this bug. Yes
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

Log into NewDot as the admin of a workspace in two devices
Go to workspace settings as admin on Device A
Go to the tags section
Make sure there are tags on the workspaces
On Device B, start creating an expense and on confirmation page press on tag to open tag picker
On Device A, delete or disable all of the tags.
On Device B Verify that you haven't created any tags message with Edit tags button appear
Press on the button and create or enable some tags you have disabled and navigate back to the tag picker
select any tag and submit the expense
Verify that the tag you selected appears in the created expense

Do you agree 👍 or 👎 ?

abekkala · 2024-10-14T08:57:58Z

PAYMENT SUMMARY

Fix: @FitseTLT [$250] Paid!
PR Review: @parasharrajat [$250] payment via NewDot

parasharrajat · 2024-12-12T11:09:55Z

Payment requested as per #48822 (comment)

JmillsExpensify · 2024-12-16T10:16:53Z

$250 approved for @parasharrajat

carlosmiceli added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 9, 2024

carlosmiceli self-assigned this Sep 9, 2024

melvin-bot bot assigned abekkala Sep 9, 2024

carlosmiceli added the External Added to denote the issue can be worked on by a contributor label Sep 9, 2024

melvin-bot bot changed the title ~~RHN throws error if tags are deleted by admin while member is selecting.~~ [$250] RHN throws error if tags are deleted by admin while member is selecting. Sep 9, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 9, 2024

melvin-bot bot assigned parasharrajat Sep 9, 2024

melvin-bot bot added the Overdue label Sep 16, 2024

carlosmiceli assigned FitseTLT Sep 16, 2024

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 16, 2024

melvin-bot bot removed the Overdue label Sep 16, 2024

melvin-bot bot added the Overdue label Sep 18, 2024

carlosmiceli added Daily KSv2 and removed Daily KSv2 labels Sep 18, 2024

melvin-bot bot removed the Overdue label Sep 18, 2024

FitseTLT mentioned this issue Sep 19, 2024

Fix - RHN throws error if tags are deleted by admin while member is selecting #49506

Merged

50 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Sep 19, 2024

abekkala closed this as completed Oct 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[$250] RHN throws error if tags are deleted by admin while member is selecting. #48822

[$250] RHN throws error if tags are deleted by admin while member is selecting. #48822

carlosmiceli commented Sep 9, 2024 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Sep 9, 2024

melvin-bot bot commented Sep 9, 2024

melvin-bot bot commented Sep 9, 2024

FitseTLT commented Sep 9, 2024 •

edited

Loading

cretadn22 commented Sep 10, 2024

FitseTLT commented Sep 10, 2024 •

edited

Loading

parasharrajat commented Sep 10, 2024

cretadn22 commented Sep 10, 2024

FitseTLT commented Sep 10, 2024

parasharrajat commented Sep 10, 2024

parasharrajat commented Sep 10, 2024

melvin-bot bot commented Sep 10, 2024

melvin-bot bot commented Sep 16, 2024

melvin-bot bot commented Sep 16, 2024

carlosmiceli commented Sep 16, 2024

FitseTLT commented Sep 18, 2024

carlosmiceli commented Sep 18, 2024

abekkala commented Oct 11, 2024

abekkala commented Oct 11, 2024

abekkala commented Oct 11, 2024 •

edited

Loading

parasharrajat commented Oct 13, 2024

abekkala commented Oct 14, 2024

parasharrajat commented Dec 12, 2024

JmillsExpensify commented Dec 16, 2024

[$250] RHN throws error if tags are deleted by admin while member is selecting. #48822

[$250] RHN throws error if tags are deleted by admin while member is selecting. #48822

Comments

carlosmiceli commented Sep 9, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Sep 9, 2024

melvin-bot bot commented Sep 9, 2024

melvin-bot bot commented Sep 9, 2024

FitseTLT commented Sep 9, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

cretadn22 commented Sep 10, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

FitseTLT commented Sep 10, 2024 • edited Loading

parasharrajat commented Sep 10, 2024

cretadn22 commented Sep 10, 2024

FitseTLT commented Sep 10, 2024

parasharrajat commented Sep 10, 2024

parasharrajat commented Sep 10, 2024

melvin-bot bot commented Sep 10, 2024

melvin-bot bot commented Sep 16, 2024

melvin-bot bot commented Sep 16, 2024

carlosmiceli commented Sep 16, 2024

FitseTLT commented Sep 18, 2024

carlosmiceli commented Sep 18, 2024

abekkala commented Oct 11, 2024

PAYMENT SUMMARY OCT 11

abekkala commented Oct 11, 2024

abekkala commented Oct 11, 2024 • edited Loading

parasharrajat commented Oct 13, 2024

Regression Test Steps

abekkala commented Oct 14, 2024

PAYMENT SUMMARY

parasharrajat commented Dec 12, 2024

JmillsExpensify commented Dec 16, 2024

carlosmiceli commented Sep 9, 2024 •

edited by melvin-bot bot

Loading

FitseTLT commented Sep 9, 2024 •

edited

Loading

FitseTLT commented Sep 10, 2024 •

edited

Loading

abekkala commented Oct 11, 2024 •

edited

Loading