[HOLD for Payment 2024-09-19][Search v2.1] Search Results Page Header Cleanup

[rayane-djouah]

This issue is a follow-up to the discussions in these links:
#46736 (comment)
#46962 (comment)

Problem:
For some filters, IDs are currently being displayed instead of names.

Objective:
We need to determine and agree on the appropriate information to show to the user.

Screenshots for Reference:

cc @luacmartins @SzymczakJ @WojtekBoman @Kicu

Issue Owner

Current Issue Owner: @289Adam289

[melvin-bot]

Triggered auto assignment to @puneetlath (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

[rayane-djouah]

Do we need to hold this until all filters are done?

[luacmartins]

This is lower priority, so let's focus on filters first.

[puneetlath]

Can one of y'all link the issue that I should put this on hold for?

[luacmartins]

Holding for #46030

[Kicu]

May I suggest we also hold for this updated after v2.1 - #47787
Reason is that after this PR the policyID value will behave slightly differently and be part of the parsed AST, and what we are showing to the user are values coming from the parsed AST. policyID should be part of the discussion I think

[luacmartins]

Done! Added to the hold list

[Kicu]

Hold on #47787 can be removed - PR was merged

[289Adam289]

As @rayane-djouah said in #47254 (comment) I think we should agree on the appropriate information to show to the user. Currently, I am taking an approach similar to how filters are displayed in AdvancedFiltersPage and just want to confirm if that's the right way. I also have two questions:

1. Do we still agree on using whitespace as a delimiter
2. Do we need type:${type} status:${status} part of header title given the contextual filters

[Kicu]

Re 2. I believe we do not want to display type and status. These will be highlighted on their respective status/type bars and buttons.

[luacmartins]

Correct, we don't need to show type/status. As for 1, yes space should still be a delimiter

[rayane-djouah]

I foresee a potential issue with type. Specifically, we deselect the LHN item (search type) if custom query, and on mobile, we display the header title in the dropdown menu button without the type.

[luacmartins]

@rayane-djouah I'm not sure that I understand the issue. Could you please clarify?

[289Adam289]

How to handle translations? For example filters:has, is, expenseType are predefined values pickers and their values are translated into Spanish. We can translate them in header but in that case I think keywords such as expenseType should be translated as well.

[luacmartins]

@289Adam289 I don't think we should translate the filters in the header for now. The query syntax doesn't support translations yet, so we'd be educating users on a feature that's not available yet.

[rayane-djouah]

Note

The production deploy automation failed: This should be on [HOLD for Payment 2024-09-19] according to #49025 production deploy checklist, confirmed in #48538 (comment)

[melvin-bot]

@puneetlath, @dannymcclain, @luacmartins, @rayane-djouah, @289Adam289 Eep! 4 days overdue now. Issues have feelings too...

[puneetlath]

@rayane-djouah it looks like you're the only one due payment here, correct? And it was for one PR?

[rayane-djouah]

@puneetlath Correct!

[puneetlath]

Great! Offer here: https://www.upwork.com/nx/wm/offer/104093170. Please ping me on this issue when you've accepted.

[rayane-djouah]

@puneetlath Offer accepted, thank you!

[puneetlath]

Great. All handled. Thanks everyone!