[$250] [P2P Distance] Track -Rate is always 0.67/mi when a different rate is selected when tracking distance expense

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.18-7
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Workspace has a few distance rates.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Click + > Track expense > Distance.
4. Proceed to confirmation page.
5. Click Rate and select a different rate.
6. Submit the track distance expense.
7. Go to transaction thread.

Expected Result:

The rate field will show the selected rate in Step 5.

Actual Result:

The rate field reverts to the default rate (0.67 per mile) instead of showing the selected rate in Step 5.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6566522_1723196820658.20240809_174220.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011112cd2e9085ed85
• Upwork Job ID: 1823303751213013161
• Last Price Increase: 2024-08-13
• Automatic offers:
• jjcoffee | Reviewer | 103538707
• Krishna2323 | Contributor | 103538708

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[IuliiaHerets]

@dylanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Track -Rate is always 0.67/mi when a different rate is selected when tracking distance expense

What is the root cause of that problem?

The trackExpense util function does not accept customUnitRateID in the params and the backend does not accept customUnitRateID and build the request accordingly, the backend always returns the default customUnitRateID.

App/src/libs/actions/IOU.ts

Lines 3632 to 3657 in 9812479

	function trackExpense(
	report: OnyxTypes.Report,
	amount: number,
	currency: string,
	created: string,
	merchant: string,
	payeeEmail: string | undefined,
	payeeAccountID: number,
	participant: Participant,
	comment: string,
	receipt?: Receipt,
	category?: string,
	tag?: string,
	taxCode = '',
	taxAmount = 0,
	billable?: boolean,
	policy?: OnyxEntry<OnyxTypes.Policy>,
	policyTagList?: OnyxEntry<OnyxTypes.PolicyTagList>,
	policyCategories?: OnyxEntry<OnyxTypes.PolicyCategories>,
	gpsPoints?: GPSPoint,
	validWaypoints?: WaypointCollection,
	action?: IOUAction,
	actionableWhisperReportActionID?: string,
	linkedTrackedExpenseReportAction?: OnyxTypes.ReportAction,
	linkedTrackedExpenseReportID?: string,
	) {

What changes do you think we should make in order to solve the problem?

• We should modify trackExpense to accept customUnitRateID as param then pass it to the parameters object in trackExpense.
• The implementation for customUnitRateID will be the same as createDistanceRequest.
• Then the backend should update the customUnitRateID accordingly.

What alternative solutions did you explore? (Optional)

[melvin-bot]

@dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[dylanexpensify]

Reviewing today!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011112cd2e9085ed85

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[jjcoffee]

@Krishna2323's proposal makes sense to me. I think it makes sense for trackExpense to support custom distance rates, but I'm not sure if there's a plan already around this so let's get some engineer eyes on this!

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @nkuoch, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[jjcoffee]

@nkuoch Do you think we can make a BE change to modify trackExpense to accept and use customUnitRateID if we pass it? Currently the BE always returns the default customUnitRateID.

[nkuoch]

cc @thienlnam or @neil-marcellini as you originally created TrackExpense command do you think you could make those changes?

[thienlnam]

I probably can't pick it up til end of next week, Neil is more familiar with the distance stuff if he's got free cycles

[neil-marcellini]

I'm also pretty busy at the moment and working 50% this week. I will assign to keep my eyes on this though and try to prioritize it soon.

[neil-marcellini]

@Krishna2323 I've chosen to implement the frontend changes myself because it makes it easy for me to test the whole flow against my backend changes. The changes are also very simple on the frontend so it doesn't make sense to pay for your proposal in this case. That's why I never assigned you or reviewed the proposal. Next time I'll try to remember to remove the Help Wanted label early on.

[neil-marcellini]

Backend changes are live, but C+ encountered issues testing so I need to investigate and fix that.

[neil-marcellini]

The issue happened on main too and was unrelated so the PR has been merged.

[jjcoffee]

Looks like the automation failed again! This hit production 2024-09-09, so this should be held for payment 2024-09-16. cc @dylanexpensify

[jjcoffee]

• The PR that introduced the bug has been identified. Link to the PR: N/A - feature was not implemented
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Go to any workspace chat that has a few different distance rates set up.
2. Click + > Track expense > Distance.
3. Proceed to confirmation page.
4. Click Rate and select a different rate (i.e. not the default 0.67/mi).
5. Submit the track distance expense.
6. Go to the transaction thread.
7. Verify the custom rate is displayed.

Do we agree 👍 or 👎

[jjcoffee]

@dylanexpensify Friendly bump for payment (see this comment for deploy deetz) 🙇

[dylanexpensify]

Payment summary:

Contributor+: @jjcoffee $250

Please apply/request!

[dylanexpensify]

@jjcoffee job post here!

[jjcoffee]

@dylanexpensify Thanks, applied!

[jjcoffee]

@dylanexpensify Friendly bump for payment 🙇

[dylanexpensify]

Working on this - Upwork is a bit buggy right now!

[melvin-bot]

@neil-marcellini, @jjcoffee, @dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@neil-marcellini, @jjcoffee, @dylanexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[neil-marcellini]

Bump @dylanexpensify

[dylanexpensify]

done!