[$250] NetSuite - Sometimes the "last synced" text is missing the actual time data

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.12-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Log in with a new expensifail account
3. Click on FAB - New workspace
4. Enable "Accounting" in the "More features" page.
5. Navigate to "Accounting"
6. Connect to NetSuite and upgrade the workspace to Control when asked
7. Wait for the sync to finish

Expected Result:

It should be showing "Last synced X minutes ago"

Actual Result:

Sometimes the "last synced" text is missing the actual time data. It can occur then the connection is made to NetSuite or if a setting is changed that forces a sync

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6552961_1721932115926.bandicam_2024-07-25_20-20-49-475.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e16d825f11c5924c
• Upwork Job ID: 1818663718833083769
• Last Price Increase: 2024-08-07

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

@greg-schroeder Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e16d825f11c5924c

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[NJ-2020]

Proposal

Please re-state the problem that we are trying to solve in this issue.

NetSuite - Sometimes the "last synced" text is missing the actual time data

What is the root cause of that problem?

On PolicyAccountingPage, we do not handle if we get an error response

App/src/pages/workspace/accounting/PolicyAccountingPage.tsx

Line 214 in 459759d

const [datetimeToRelative, setDateTimeToRelative] = useState('');

App/src/pages/workspace/accounting/PolicyAccountingPage.tsx

Lines 229 to 232 in 459759d

	const successfulDate = getIntegrationLastSuccessfulDate(
	connectedIntegration ? policy?.connections?.[connectedIntegration] : undefined,
	connectedIntegration === connectionSyncProgress?.connectionName ? connectionSyncProgress : undefined,
	);

App/src/pages/workspace/accounting/PolicyAccountingPage.tsx

Lines 363 to 364 in 459759d

	? translate('workspace.accounting.connections.syncStageName', connectionSyncProgress.stageInProgress)
	: translate('workspace.accounting.lastSync', datetimeToRelative),

What changes do you think we should make in order to solve the problem?

We can create a new variable for lastSynced date if the response is error .lastErrorSyncedData, and use this variable if the connection is error and use the successfulDate variable if the connection is success

Or we can make it in one variable checking if error we can use the lastErrorSyncedData and if success we can use the successfulDate variable

What alternative solutions did you explore? (Optional)

[greg-schroeder]

Next up is @alitoshmatov for proposal review

[greg-schroeder]

Go away melvin

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@greg-schroeder @alitoshmatov this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@greg-schroeder, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[alitoshmatov]

Requested access to Netsuite in slack.

[shubham1206agra]

This is a BE issue. Already asked @yuwenmemon for a fix. Will be fixed after he comes back from OOO

[melvin-bot]

@greg-schroeder, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[greg-schroeder]

Okay - adjusting to Internal

[NJ-2020]

Is the issue has been fixed in BE?
The issue still reproducible if I provide with invalid credentials

cc: @greg-schroeder

[melvin-bot]

@yuwenmemon, @greg-schroeder, @alitoshmatov Whoops! This issue is 2 days overdue. Let's get this updated quick!

[greg-schroeder]

Hmm - @yuwenmemon I see your PR was deployed and is due to resolve the phantom "last synced" issue. But that looks slightly different than what's been pointed out here... this has a failed connection instead of a successful one.

Would you consider that a separate issue?

[yuwenmemon]

Yep, we're going to be tackling that here: #47493

[melvin-bot]

@yuwenmemon, @greg-schroeder, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@yuwenmemon, @greg-schroeder, @alitoshmatov Eep! 4 days overdue now. Issues have feelings too...

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[greg-schroeder]

Okay, so the issue brought up in this issue was fixed, then, and the other thing that was mentioned is being fixed elsewhere. Closing then.