Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [HelpDot] back should go to previous page #42600

Closed
rushatgabhane opened this issue May 24, 2024 · 80 comments
Closed

[$250] [HelpDot] back should go to previous page #42600

rushatgabhane opened this issue May 24, 2024 · 80 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Monthly KSv2

Comments

@rushatgabhane
Copy link
Member

rushatgabhane commented May 24, 2024

https://expensify.enterprise.slack.com/archives/C02QSAC6BJ8/p1716512720894059

  1. When navigating on help.expensify.com, back should take you to the previous page
  2. LHN highlight position isn't accurate
Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0147f1debc6f7ab719
  • Upwork Job ID: 1801285227792706387
  • Last Price Increase: 2024-08-20
  • Automatic offers:
    • wildan-m | Contributor | 103733105
Issue OwnerCurrent Issue Owner: @rushatgabhane
@rushatgabhane rushatgabhane added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels May 24, 2024
Copy link

melvin-bot bot commented May 24, 2024

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented May 27, 2024

@rushatgabhane, @maddylewis Whoops! This issue is 2 days overdue. Let's get this updated quick!

@maddylewis
Copy link
Contributor

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 28, 2024
Copy link

melvin-bot bot commented May 31, 2024

@rushatgabhane, @maddylewis Whoops! This issue is 2 days overdue. Let's get this updated quick!

@rushatgabhane
Copy link
Member Author

not overdue

@melvin-bot melvin-bot bot removed the Overdue label May 31, 2024
Copy link

melvin-bot bot commented Jun 3, 2024

@rushatgabhane, @maddylewis Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Jun 6, 2024

@rushatgabhane, @maddylewis Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Jun 6, 2024
@rushatgabhane
Copy link
Member Author

im exploring browser apis to achieve this

@melvin-bot melvin-bot bot removed the Overdue label Jun 6, 2024
Copy link

melvin-bot bot commented Jun 7, 2024

@rushatgabhane @maddylewis this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@rushatgabhane
Copy link
Member Author

still didn't find anything

@melvin-bot melvin-bot bot added the Overdue label Jun 13, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jun 13, 2024
@maddylewis maddylewis reopened this Jun 13, 2024
@maddylewis maddylewis added the External Added to denote the issue can be worked on by a contributor label Jun 13, 2024
@melvin-bot melvin-bot bot changed the title [HelpDot] back should go to previous page [$250] [HelpDot] back should go to previous page Jun 13, 2024
@wildan-m
Copy link
Contributor

Proposal Updated

  • remove unnecessary code

@Gonals
Copy link
Contributor

Gonals commented Aug 22, 2024

Not overdue. We are getting some proposals

Copy link

melvin-bot bot commented Aug 23, 2024

@Gonals, @mallenexpensify, @rushatgabhane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@mallenexpensify
Copy link
Contributor

@rushatgabhane , 👀 on @wildan-m 's proposal above plz
#42600 (comment)

@rushatgabhane
Copy link
Member Author

@wildan-m

# links are useful because they take you to a specific section on a page

I don't think we should remove them

@melvin-bot melvin-bot bot removed the Overdue label Aug 26, 2024
@wildan-m
Copy link
Contributor

@rushatgabhane my solutions keep the #hash link, but not record the link in browser history on each menu click. Please try my branch in the proposal.

@rushatgabhane
Copy link
Member Author

Ahhhh nice

I like your proposal @wildan-m
🎀 👀 🎀

Copy link

melvin-bot bot commented Aug 27, 2024

Current assignee @Gonals is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 29, 2024
Copy link

melvin-bot bot commented Aug 29, 2024

📣 @wildan-m 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@wildan-m
Copy link
Contributor

@rushatgabhane PR ready for review at #48273

@rushatgabhane
Copy link
Member Author

@mallenexpensify PR in production 1 week ago. We can close here

@mallenexpensify
Copy link
Contributor

Contributor: @wildan-m paid $250 via Upwork

@rushatgabhane , I'm assuming you're not paid here cuz you're working on help projects.
hmm... do we want a regression test for this? Seems like we would, unless a test is being added elsewhere as part of a project.

@mallenexpensify mallenexpensify added Daily KSv2 Weekly KSv2 and removed Reviewing Has a PR in review Weekly KSv2 Daily KSv2 labels Sep 10, 2024
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Oct 7, 2024
Copy link

melvin-bot bot commented Oct 7, 2024

This issue has not been updated in over 15 days. @wildan-m, @Gonals, @mallenexpensify, @rushatgabhane eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Monthly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants