[Hold for 40548] [$500] iOS - Chat - Send button is not responding after viewing avatar in full screen

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.64-2
Reproducible in staging?: y
Reproducible in production?: y
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch New Expensify app.
2. Go to 1:1 DM.
3. Tap on the chat header.
4. Tap on the avatar.
5. Return to main chat.
6. Send a message.

Expected Result:

The message is sent after tapping on the send button.

Actual Result:

The send button is not responding after viewing avatar in full screen.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6458783_1713876730104.RPReplay_Final1713876464.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012e8723cf045e9a77
• Upwork Job ID: 1782791638422151168
• Last Price Increase: 2024-06-24

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[kbecciv]

We think that this bug might be related to #vip-vsb

[kbecciv]

@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012e8723cf045e9a77

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[debski-patrick]

Would much appreciate if you can share a related branch and pull request so that I can analyze the codebase.

[melvin-bot]

📣 @stefan2do! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[sword1202]

Proposal

Please re-state the problem that we are trying to solve in this issue.

help-wanted.40797.mp4

"Send" Button does not work, but we can send comment in out of MessageBox.

help-wanted.40797_case1.mp4

What is the root cause of that problem?

The problem comes from Design Style in the button and Rendering from Navigating back.

What changes do you think we should make in order to solve the problem?

We should update this style for Send button to resolve the issue.

###Attached Working file. I am sure I solved the issue.

25.04.2024_17.14.26_REC.mp4

[sword1202]

Proposal

Updated

[kaushiktd]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Self DM - Chat is not scrolled to the bottom when clicking 'New message'

What is the root cause of that problem?

onEnd(callback) will only be called if the handler was previously in the active state. When the user loads the report, it has an active state, but when the user navigates away and back to the report, it no longer has an active state, so onEnd is not callable. This is the main root cause here.

What changes do you think we should make in order to solve the problem?

You need to remove GestureDetector from here.
also The onPress event for PressableWithFeedback needs to be added here.

onPress={handleSendMessage}

You need to update line# 365 here as mention below. To remove setNativeProps() warning message.

runOnUI(() => {
    setNativeProps(animatedRef, {text: ''}); // clears native text input on the UI thread
});

Please import runOnUI as react-native-reanimated like below:

import {runOnJS, runOnUI, setNativeProps, useAnimatedRef} from 'react-native-reanimated';

Video

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-04-25.at.13.43.22.mp4

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[sword1202]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~0194d962e1f9098218
Updated. My profile was set to private. I am placing proposal.

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[sword1202]

Proposal

Updated

[sword1202]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~0194d962e1f9098218

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[bfitzexpensify]

Couple of proposals ready for review @abdulrahuman5196

[sword1202]

Isn't there anybody to check proposal?
I sent Slack invites for many times, but not response.
Please advise

[abdulrahuman5196]

Sorry for the delay. Checking now.

[QichenZhu]

Proposal

Updated

[github-actions]

[GitHub User] Your proposal will be dismissed because you did not follow the proposal template.

[melvin-bot]

@bfitzexpensify, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

[bfitzexpensify]

This one is older so maybe we can close #41528 if duplicate

Agreed, closed it out

[bfitzexpensify]

Moving this back to weekly while it is held on #40548

[bfitzexpensify]

Remains held

[aimane-chnaif]

RN upgrade PR was merged and reached staging

[aimane-chnaif]

We can remove hold.
@QichenZhu Is this still reproducible? And is your proposal still valid?

[bfitzexpensify]

I am heading out of office until September 21st, so assigning a buddy to watch over this in my absence.

Current status: Asking QA to retest via https://expensify.slack.com/archives/C9YU7BX5M/p1725634492745089

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[kavimuru]

Not reproducible

ScreenRecording_09-06-2024.23-11-38_1.MP4

[QichenZhu]

@aimane-chnaif I cannot reproduce it either.

@anmurali Sorry, mentioned you by mistake.

[slafortune]

Thanks @QichenZhu and @kavimuru - I appreciate the testing!

Closing