-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-05-20] iOS - Wallet - Missing up and down key and Done button in the header of account selection list #40126
Comments
Triggered auto assignment to @luacmartins ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@luacmartins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
We think that this bug might be related to #wave-collect - Выпуск 1 |
Production: RPReplay_Final1712850391.MP4 |
I think we can demote this to NAB and make it external, since the functionality is not broken. |
Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia ( |
Triggered auto assignment to @kevinksullivan ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.iOS - Wallet - Missing up and down key and Done button in the header of account selection list What is the root cause of that problem?I tried to debug and find the root cause but couldn't locate it. However, during element inspection, I noticed that What changes do you think we should make in order to solve the problem?We can update the Lines 785 to 787 in 8ae5491
What alternative solutions did you explore? (Optional)We can hide the Examples: https://snack.expo.dev/@lfkwtz/react-native-picker-select?platform=ios If we want we can only hide
|
ProposalPlease re-state the problem that we are trying to solve in this issue.iOS - Wallet - Missing up and down key and Done button in the header of account selection list What is the root cause of that problem?This problem is relevant for ALL pickers The main problem is that zIndex:2 was added to the picker header https://github.com/lawnstarter/react-native-picker-select/blob/master/src/styles.js#L23 But now it causes a problem with the display of the element What changes do you think we should make to solve the problem?To fix this issue we can add This will save us from potential problems, which is associated with the reason for adding zIndex Plus if we want we can update logic for up and down arrows or hide them using props from documentation What alternative solutions did you explore? (Optional)NA |
I am Michał from Callstack - expert contributor group. I’d like to work on this job. I see one effective alternative solution straight away here but we would need someone from UX team to speak on that. A while ago we've refactored BA flow where we replaced this picker with a list of radio buttons. I can see in the codebase that we're already using this radio buttons list in 2 of 3 places if I'm not mistaken and Wallet is the only place left where we're using the old picker component. What could be done is we could drop the picker completely and move to this new design of list of radio buttons. Posting a screenshot of how it could look like below - |
@thesahindia did you get a chance to look at the proposals above? |
I think we should ask the design team for their opinion about #40126 (comment) |
I think we need to fix this bug anyway |
@luacmartins, @kevinksullivan, @MrMuzyk, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick! |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-05-20. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payment Summary
BugZero Checklist (@kevinksullivan)
|
Confirmed summary is accurate. @thesahindia can you finish out the checklist above? |
Not a regression. It was a minor issue and we don't need a test case for this. |
@luacmartins, @kevinksullivan, @MrMuzyk, @thesahindia Huh... This is 4 days overdue. Who can take care of this? |
$250 approved for @thesahindia |
@luacmartins, @kevinksullivan, @MrMuzyk, @thesahindia 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it! |
Are we good to close this one? |
Yeah, we can close this. |
Awesome! Thanks everyone! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.62-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
There will be up and down button and the word "Done" in the header in account selection list (screenshot from 1.4.61-8)
Actual Result:
The header in account selection list is empty
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6445965_1712846010759.RPReplay_Final1712845359.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @kevinksullivanThe text was updated successfully, but these errors were encountered: