Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-05-20] iOS - Wallet - Missing up and down key and Done button in the header of account selection list #40126

Closed
1 of 6 tasks
lanitochka17 opened this issue Apr 11, 2024 · 48 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@lanitochka17
Copy link

lanitochka17 commented Apr 11, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.62-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch New Expensify app
  2. Go to Profile > Wallet
  3. Add a personal bank account
  4. After returning to ND from Plaid, note the header in account selection list

Expected Result:

There will be up and down button and the word "Done" in the header in account selection list (screenshot from 1.4.61-8)

Actual Result:

The header in account selection list is empty

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6445965_1712846010759.RPReplay_Final1712845359.mp4

Bug6445965_1712846010774!1 4 62-3

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @kevinksullivan
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Apr 11, 2024
Copy link

melvin-bot bot commented Apr 11, 2024

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@luacmartins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-collect - Выпуск 1

@lanitochka17
Copy link
Author

Production:

RPReplay_Final1712850391.MP4

@luacmartins
Copy link
Contributor

I think we can demote this to NAB and make it external, since the functionality is not broken.

@luacmartins luacmartins added Daily KSv2 External Added to denote the issue can be worked on by a contributor Bug Something is broken. Auto assigns a BugZero manager. and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 11, 2024
Copy link

melvin-bot bot commented Apr 11, 2024

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 11, 2024
Copy link

melvin-bot bot commented Apr 11, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

Copy link

melvin-bot bot commented Apr 11, 2024

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@Krishna2323
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - Wallet - Missing up and down key and Done button in the header of account selection list

What is the root cause of that problem?

I tried to debug and find the root cause but couldn't locate it. However, during element inspection, I noticed that modalViewMiddle had a zIndex of 2, and updating it to -1 or 0 resolved the issue.

What changes do you think we should make in order to solve the problem?

We can update the zIndex of modalViewMiddle here:

App/src/styles/index.ts

Lines 785 to 787 in 8ae5491

modalViewMiddle: {
backgroundColor: theme.border,
borderTopWidth: 0,

What alternative solutions did you explore? (Optional)

We can hide the modalViewMiddle using InputAccessoryView or we can add functionality to up/down arrow keys using onUpArrow & onDownArrow

Examples: https://snack.expo.dev/@lfkwtz/react-native-picker-select?platform=ios

If we want we can only hide up/down arrows by applying styles to chevronContainer.

chevronContainer: {
    pointerEvents: 'none',
    opacity: 0,
},

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Apr 11, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - Wallet - Missing up and down key and Done button in the header of account selection list

What is the root cause of that problem?

This problem is relevant for ALL pickers

The main problem is that zIndex:2 was added to the picker header
Because it fixed one bug

https://github.com/lawnstarter/react-native-picker-select/blob/master/src/styles.js#L23
lawnstarter/react-native-picker-select#209

But now it causes a problem with the display of the element
Since looking at this topic, I concluded that the new architecture sometimes does not work correctly with zIndex

facebook/react-native#38513

What changes do you think we should make to solve the problem?

To fix this issue we can add position: 'relative' for modalViewMiddle to zIndex works correctly

This will save us from potential problems, which is associated with the reason for adding zIndex
But it will also allow us to display the header correctly

Screenshot 2024-04-11 at 21 02 16

Plus if we want we can update logic for up and down arrows or hide them using props from documentation

https://github.com/lawnstarter/react-native-picker-select?tab=readme-ov-file#props

What alternative solutions did you explore? (Optional)

NA

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Apr 12, 2024

I am Michał from Callstack - expert contributor group. I’d like to work on this job.

I see one effective alternative solution straight away here but we would need someone from UX team to speak on that. A while ago we've refactored BA flow where we replaced this picker with a list of radio buttons. I can see in the codebase that we're already using this radio buttons list in 2 of 3 places if I'm not mistaken and Wallet is the only place left where we're using the old picker component. What could be done is we could drop the picker completely and move to this new design of list of radio buttons. Posting a screenshot of how it could look like below -

image

@melvin-bot melvin-bot bot added the Overdue label Apr 15, 2024
@luacmartins
Copy link
Contributor

@thesahindia did you get a chance to look at the proposals above?

@melvin-bot melvin-bot bot removed the Overdue label Apr 15, 2024
@thesahindia
Copy link
Member

I think we should ask the design team for their opinion about #40126 (comment)

@ZhenjaHorbach
Copy link
Contributor

I think we need to fix this bug anyway
Because this problem is relevant for ALL pickers (Not only the account selection list)

Copy link

melvin-bot bot commented May 3, 2024

@luacmartins, @kevinksullivan, @MrMuzyk, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Overdue Weekly KSv2 labels May 6, 2024
@melvin-bot melvin-bot bot changed the title iOS - Wallet - Missing up and down key and Done button in the header of account selection list [HOLD for payment 2024-05-20] iOS - Wallet - Missing up and down key and Done button in the header of account selection list May 13, 2024
Copy link

melvin-bot bot commented May 13, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 13, 2024
Copy link

melvin-bot bot commented May 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-05-20. 🎊

For reference, here are some details about the assignees on this issue:

  • @MrMuzyk does not require payment (Contractor)
  • @thesahindia requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented May 13, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
  • [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@thesahindia] Determine if we should create a regression test for this bug.
  • [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 19, 2024
Copy link

melvin-bot bot commented May 20, 2024

Payment Summary

Upwork Job

  • Contributor: @MrMuzyk is from an agency-contributor and not due payment
  • Reviewer: @thesahindia owed $250 via NewDot

BugZero Checklist (@kevinksullivan)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label May 21, 2024
@kevinksullivan
Copy link
Contributor

Confirmed summary is accurate. @thesahindia can you finish out the checklist above?

@melvin-bot melvin-bot bot removed the Overdue label May 21, 2024
@thesahindia
Copy link
Member

Not a regression. It was a minor issue and we don't need a test case for this.

@melvin-bot melvin-bot bot added the Overdue label May 24, 2024
Copy link

melvin-bot bot commented May 27, 2024

@luacmartins, @kevinksullivan, @MrMuzyk, @thesahindia Huh... This is 4 days overdue. Who can take care of this?

@JmillsExpensify
Copy link

$250 approved for @thesahindia

Copy link

melvin-bot bot commented May 31, 2024

@luacmartins, @kevinksullivan, @MrMuzyk, @thesahindia 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@luacmartins
Copy link
Contributor

Are we good to close this one?

@thesahindia
Copy link
Member

Yeah, we can close this.

@luacmartins
Copy link
Contributor

Awesome! Thanks everyone!

@melvin-bot melvin-bot bot removed the Overdue label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests