[HOLD for payment 2023-11-17] [$500] Chat - Pressing Tab closes emoji picker on Desktop or moves focus to the composer on Web

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.97-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Go to staging.new.expensify.com or open Desktop App
2. Login with any account
3. Go to any chat
4. Open emoji picker
5. Press 'Tab' key

Expected Result:

Focus moves to the next item -> from 'Search' field to ‘Frequently Used’ icon

Actual Result:

Pressing Tab closes emoji picker on Desktop or moves focus to the composer on Web (Safari)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6269431_1699495498198.Desktop-Tab-close-emoji-picker.mp4

Bug6269431_1699495498204.Safari-Tab-move-focus-from-emoji-picker.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016146f3b3888a9471
• Upwork Job ID: 1722537804750688256
• Last Price Increase: 2023-11-09
• Automatic offers:
• tienifr | Contributor | 27591485

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016146f3b3888a9471

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (External)

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[bernhardoj]

Regression from #30777. All pressable tabIndex is -1 which does not allow us to navigate with TAB key.

App/src/components/Pressable/GenericPressable/index.tsx

Line 13 in 5a94095

tabIndex={!props.accessible || !props.focusable ? -1 : 0}

Both accessible and focusable are undefined. Previously, accessible default value is true.

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Pressing Tab closes emoji picker on Desktop or moves focus to the composer on Web

What is the root cause of that problem?

In here, we set tabIndex = -1 if !props.accessible || !props.focusable. And we did not set the default value for accessible and focusable so they are undefined

-> That makes tabIndex = -1

What changes do you think we should make in order to solve the problem?

Set default value is true for 2 these value

function WebGenericPressable({focusable=true,...props}: PressableProps, ref: ForwardedRef<View>) {
    const accessible = props.accessible || isUndefined(props.accessible) ? true:  props.accessible

...
tabIndex={!accessible || !focusable ? -1 : 0}

[blazejkustra]

Regression from #30777. All pressable tabIndex is -1 which does not allow us to navigate with TAB key.

App/src/components/Pressable/GenericPressable/index.tsx

Line 13 in 5a94095

tabIndex={!props.accessible || !props.focusable ? -1 : 0}

Both accessible and focusable are undefined. Previously, accessible default value is true.

Actually it isn't a regression from Pressable migration PR. I verified this when I reverted Pressable migration on the newest main. I think RN-web upgrade caused the regression.

[blazejkustra]

That being said I think the proposal proposed by @tienifr seems to fix it!

[aimane-chnaif]

@tienifr when submit proposal on deploy blocker issues, find the offending PR and point out the exact line in PR changes which caused the issue. Only this can be considered as correct root cause.

[mountiny]

Ideally also verify it by reverting the PR. @tienifr Are you able to create the PR quickly?

[tienifr]

PR ready for review #31118.

[mountiny]

Asking for a CP

[mountiny]

Fixed only payment to @tienifr for the fix, $500

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.97-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix: Cannot navigate by Tab key #31118

If no regressions arise, payment will be issued on 2023-11-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @tienifr requires payment offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@tienifr] Determine if we should create a regression test for this bug.
• [@tienifr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.98-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix: Cannot navigate by Tab key #31118

If no regressions arise, payment will be issued on 2023-11-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @tienifr requires payment offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@tienifr] Determine if we should create a regression test for this bug.
• [@tienifr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

@tienifr Can you please handle the checklist?

[tienifr]

@mountiny I'm not a C+, the PR was reviewed and approved by you.

[mountiny]

The offending PR was identified as the RNW upgrade f4f44ae, it changed someexpected behavioru, it was auge lift and big upgrade which had lots of small regressions we are aware of. No need to start discussion.

No regression test required imho, its an edge case.

@isabelastisser should bre ready to be paid

[situchan]

There are some flags that the PR caused these regressions: #31203, #31488

[isabelastisser]

@tienifr, I just made the payment in Upwork. All set!