[HOLD for payment 2024-01-31] Web - Chat - Cursor shows a hand instead of a text cursor "I" when hovering over text in code block

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

**Version Number:**1.3.97-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Navigate to staging.new.expensify.com
2. Go to any chat
3. Send a code block
4. Hover over code block

Expected Result:

The cursor shows a text cursor "I"

Actual Result:

The cursor shows a hand cursor

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6269354_1699487008095.code_block.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[sophiepintoraetz]

Hmm, I'm not able to reproduce this and I don't think this is a deploy blocker - @tylerkaraszewski - do you agree?

[s-alves10]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pointer cursor shows instead of text cursor when hovering over the code block

What is the root cause of that problem?

We removed the role 'text' and use 'presentation' instead(from the PR #24482)
But we're still use 'text' below to set the cursor

App/src/components/Pressable/GenericPressable/BaseGenericPressable.tsx

Line 135 in a63a896

getCursorStyle(shouldUseDisabledCursor, [rest.accessibilityRole, rest.role].includes('text')),

Also we replaced the accessibilityRole with role in the same PR, but we're still using accessibilityRole below

App/src/components/Pressable/GenericPressable/index.tsx

Line 14 in dee9b31

role={props.accessibilityRole as Role}

This is the root cause

What changes do you think we should make in order to solve the problem?

We should use the CONST.ACCESSIBILITY_ROLE.TEXT instead of `text' here

App/src/components/Pressable/GenericPressable/BaseGenericPressable.tsx

Line 135 in a63a896

getCursorStyle(shouldUseDisabledCursor, [rest.accessibilityRole, rest.role].includes('text')),

And remove this line

App/src/components/Pressable/GenericPressable/index.tsx

Line 14 in dee9b31

role={props.accessibilityRole as Role}

This works as expected

Result

31085.mp4

What alternative solutions did you explore? (Optional)

[s-alves10]

@sophiepintoraetz

This issue is reproducible in staging(version: 1.3.97-1), but not in production.

[sophiepintoraetz]

@s-alves10 - my URL shows it's staging.

[aimane-chnaif]

@getusha can you please check this?

[s-alves10]

@sophiepintoraetz @tylerkaraszewski

Yeah. It looks like you used "`". Please try with "```"

[s-alves10]

#24482 (comment)

[getusha]

Seems like a minor issue we missed i can raise a PR to fix it.

[s-alves10]

There are some other places we need to replace(accessibilityRole -> role)

[sophiepintoraetz]

Ah yes, thanks for the correct, @s-alves10 - able to reproduce!

[tylerkaraszewski]

This is pretty minor, I am going to remove the deploy blocker tag and assign @getusha to fix it.

[melvin-bot]

@tylerkaraszewski, @sophiepintoraetz, @getusha, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[situchan]

PR is in review

[melvin-bot]

@tylerkaraszewski, @sophiepintoraetz, @getusha, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[getusha]

PR merged recently.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.30-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix wrong cursor style based on accessibility role #31605

If no regressions arise, payment will be issued on 2024-01-31. 🎊

For reference, here are some details about the assignees on this issue:

• @getusha requires payment (Needs manual offer from BZ)
• @situchan requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@getusha / @situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@getusha / @situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@getusha / @situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@getusha / @situchan] Determine if we should create a regression test for this bug.
• [@getusha / @situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sophiepintoraetz]

Offers sent @getusha and @situchan! @situchan - can you complete the checklist please?

[situchan]

• The PR that introduced the bug has been identified. Link to the PR: Upgrade to react-native-web v0.19.9 #24482
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: It was large PR and PR author (@getusha) is aware of it and thus fixed it
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. No need regression test as this is super minor and caught by QA team during staging regression testing
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @getusha paid $(AMOUNT) via Upwork (LINK)
• ROLE: @situchan paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@sophiepintoraetz)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MitchExpensify]

Sorry to ask but I'm having trouble tracking down the contracts for this job in Upwork. Mind sharing the links here for payment @getusha @situchan ? Thanks

[MitchExpensify]

Friendly bump on the above, I took another look but don't see anything - Do I need to create contracts for you both @getusha @situchan ?

[situchan]

Payment is handled already by @sophiepintoraetz
We can close this

[getusha]

I assume i am not eligible to get paid since we handled it as a regression.

[MitchExpensify]

I assume i am not eligible to get paid since we handled it as a regression.

Typically yes - No additional payment on regression issues