-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Chat - Inconsistency in displaying unread green line when navigating from thread #31026
Comments
Job added to Upwork: https://www.upwork.com/jobs/~01e2d8d823ccdf91aa |
Triggered auto assignment to @JmillsExpensify ( |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws ( |
This issue will be fixed by #30696 (comment) Will you take a look? |
ProposalPlease re-state the problem that we are trying to solve in this issue.There are some inconsistencies in displaying unread green line marker when navigating from and to thread What is the root cause of that problem?The main issue is in weird logic of the following code App/src/pages/home/report/ReportActionsList.js Lines 324 to 330 in 9cecdfa
What changes do you think we should make in order to solve the problem?
This works as expected What alternative solutions did you explore? (Optional) |
ProposalPlease re-state the problem that we are trying to solve in this issue.Inconsistency in displaying unread green line when navigating from thread What is the root cause of that problem?When a user reply in thread and navigate to the same report via the subtitle link (repeatedly) report screens with the same report will exist in the navigation stack so when the user navigates back they will navigate back to the report screen with the same report in it's previous state as we are not reseting What changes do you think we should make in order to solve the problem?In RepotActionList We need to have a
We can also use And additionally if we want we can call |
@s-alves10 to proof that your solution doesn't work just on your suggested changes applied, mark as unread a report action and refresh the page now the marker is expected to be displayed as the logic of mark as unread is to have that marker when next time a user opens the report. But in your case the marker will display for a sec and it disappears when App/src/pages/home/report/ReportActionsList.js Lines 306 to 309 in b8f91a4
In my opinion, all other logic is working fine (expect the unnecessary dependencies you mentioned which we can remove) so I suggest we only fix this specific issue. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Inconsistency in displaying unread green line when navigating from thread What is the root cause of that problem?The App/src/pages/home/report/ReportActionsList.js Lines 300 to 313 in dee9b31
The App/src/pages/home/report/ReportActionsList.js Lines 332 to 334 in dee9b31
Hence, when the What changes do you think we should make in order to solve the problem?We should fix the logic in the
Therefore, slightly editing the code above to something similar to this should prohibit the unread line from appearing when navigating back to the report.
|
Will have a look at this one today. |
This only seems to apply if we add |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
No @Ollyws it applies without adding
it will result in the removal of the new marker. Generally, the illusion this proposal is making to seem like it is solving the issue is b/c it is breaking an already working logic of the component to sustain the marker as long as the user is on that screen which depends on the logic in shouldDisplayNewMarker that sets shouldDisplay true for the report action which is the currentUnreadMarker (whenever currentUnreadMarker is not null).
|
Self assigning this issue |
Putting this on HOLD for #27456 |
@JmillsExpensify, @Ollyws, @MonilBhavsar Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Still on hold, bumping to weekly |
Issue not reproducible during KI retests. (Second week) |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
It is still reproducible @mvtglobally Please follow the steps and video in OP. You have to 2024-04-04.20-52-44.mp4 |
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989 |
Needs to be reproduced and confirmed by QA team. |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Issue is reproducible during KI retests. 1712759104485.0-02-01-ec6d3a4ef5057233e15b03f52bf53a1cc48c2cb51ea54f62db2b79d6cdc16638_7a4fa2c97dc8e2ed.mp4 |
Current assignee @MonilBhavsar is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new. |
👍 Let's test it extensively to ensure we don't introduce any regression since it refactors core logic. |
📣 @Ollyws 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@MonilBhavsar We don't have access to it 😢 |
Oops sorry, Pasting it here Unread tests
|
Thx |
@FitseTLT what's the ETA for the PR? |
@MonilBhavsar After #40315 now the subtitle link will |
Okay, thanks for clarifying. Let's reopen if reproducible |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.3.96-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
The green line for unread message will not show up since the unread message is visited and the green line is gone in Step 9
Actual Result:
The green line for unread message reappears
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6267891_1699386933157.Screen_Recording_20231107_222134_New_Expensify.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: