Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch the NoClassDefFoundError if it's thrown #90

Merged
merged 2 commits into from
May 19, 2021

Conversation

wheelerlaw
Copy link
Contributor

@wheelerlaw wheelerlaw commented Nov 12, 2020

Summary

See #89. It looks like newer versions of the JRE throw a different exception for Class::forName. It used to be ClassNotFoundException but Java 11 appears to be throwing the same exception but wrapped in a NoClassDefFoundError.

Additional Details

n/a

Checklist

Testing

(Remove this checklist and replace it with "N/A - no code changes" if this PR does not modify source code)

  • I have manually verified that my code changes do the right thing.
  • I have run the tests and verified that my changes do not introduce any regressions.
  • I have written unit tests to verify that my code changes do the right thing and to protect my code against regressions

Documentation

(Remove this checklist and replace it with "N/A - no code changes" if this PR does not modify source code)

  • I have updated the "Unreleased" section of CHANGELOG.md with a brief description of my changes.
  • I have updated code comments - both GroovyDoc/JavaDoc-style comments and inline comments - where appropriate.
  • I have read CONTRIBUTING.md and have followed its guidance.

@awittha awittha self-assigned this Apr 13, 2021
@awittha awittha merged commit ce62709 into ExpediaGroup:master May 19, 2021
@JustusNBB
Copy link

Please release, this error is a headache on JDK 11 ;)

@wheelerlaw wheelerlaw deleted the java-11-compatibility branch October 28, 2021 18:04
@corporate-gadfly
Copy link

Any chance of a 2.1.6 release?

@mrlov
Copy link

mrlov commented Feb 14, 2023

Please release 🥺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants