Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pom.xml files in the examples so that they can run with a more re… #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jovo3
Copy link

@jovo3 jovo3 commented May 28, 2020

…cent JDK

Error seen when running the examples:
Source option 5 is no longer supported. Use 6 or later.

Summary

Please briefly describe how this Pull Request changes the project.

Additional Details

If necessary, provide additional context or details about this Pull Request.

Checklist

Testing

(Remove this checklist and replace it with "N/A - no code changes" if this PR does not modify source code)

  • I have manually verified that my code changes do the right thing.
  • I have run the tests and verified that my changes do not introduce any regressions.
  • I have written unit tests to verify that my code changes do the right thing and to protect my code against regressions

Documentation

(Remove this checklist and replace it with "N/A - no code changes" if this PR does not modify source code)

  • I have updated the "Unreleased" section of CHANGELOG.md with a brief description of my changes.
  • I have updated code comments - both GroovyDoc/JavaDoc-style comments and inline comments - where appropriate.
  • I have read CONTRIBUTING.md and have followed its guidance.

…cent JDK

Error seen when running the examples:
Source option 5 is no longer supported. Use 6 or later.
Copy link
Contributor

@awittha awittha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please parameterize the plugin version into <properties>.

For an example, see how the gmavenplus plugin's version is parameterized here:

<groovy.gmaven.pluginVersion>1.6.1</groovy.gmaven.pluginVersion>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants