Perf #9
Closed
Perf #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonaye
reviewed
Jun 8, 2020
| const fixedStyleProps = multi ? fixedStyle : { style: fixedStyle } | ||
| const fixedStyleKeys = Object.keys(fixedStyleProps) | ||
|
|
||
| for (let i = 0; i < fixedStyleKeys.length; i += 1) { |
There was a problem hiding this comment.
You are assuming styleKeys.length is equal fixedStyleKeys.length?
There was a problem hiding this comment.
Nice catch, that is a bug, will update
|
After fixing #9 (comment) I no longer see significant perf gains, so not worth changing without evaluating on the cases in our app. Will close as future for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly improves perf by:
Measurements using https://github.com/andrejborstnik/benchmark. Big variance in results, but after is consistently faster, as expected.
Before:
After:
