Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add omitProps #30

Merged
merged 2 commits into from
Feb 3, 2025
Merged

feat: add omitProps #30

merged 2 commits into from
Feb 3, 2025

Conversation

alexandr-bbm
Copy link
Contributor

Adds omitProps config with default to omit theme prop passing since its a common use case to wrap the component with withTheme for styles only needed in shakl's style callback but not inside actual component.

Closes: https://app.asana.com/0/1201379636186833/1209212141439843

@alexandr-bbm
Copy link
Contributor Author

no significant change of yarn benchmark before/after

before | after     
                   
0.0386 | 0.0360    
0.0355 | 0.0351    
0.0357 | 0.0352

headfire94
headfire94 approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@headfire94 headfire94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK thanks

sparten11740
sparten11740 reviewed Jan 31, 2025
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
sparten11740
sparten11740 approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@sparten11740 sparten11740 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint failing, otherwise lg 👍🏼

hancandice
hancandice approved these changes Feb 1, 2025
View reviewed changes
Copy link

@hancandice hancandice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 👍🏼

src/index.ts Show resolved Hide resolved
@alexandr-bbm alexandr-bbm force-pushed the alexandr-bbm/feat/add-omit-props branch from 910c013 to 30dafc0 Compare February 3, 2025 11:45
@alexandr-bbm alexandr-bbm merged commit 9c3e599 into master Feb 3, 2025
4 checks passed
@alexandr-bbm
Copy link
Contributor Author

@headfire94 I don't have access rights to publish

@headfire94
Copy link
Contributor

@alexandrius can you publish it?

@alexandrius
Copy link
Contributor

done

@alexandr-bbm
Copy link
Contributor Author

@alexandrius a bit confusing we still have "version": "0.0.16" in package.json, should we update there to 0.0.20?

@alexandr-bbm alexandr-bbm mentioned this pull request Feb 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sparten11740 sparten11740 sparten11740 approved these changes

@headfire94 headfire94 headfire94 approved these changes

@hancandice hancandice hancandice approved these changes

@alexandrius alexandrius Awaiting requested review from alexandrius

@bekatd bekatd Awaiting requested review from bekatd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexandr-bbm @headfire94 @alexandrius @sparten11740 @hancandice