Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export all types and make them generic #18

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

headfire94
Copy link
Contributor

need to export types to be able to extend|merge them

@headfire94 headfire94 self-assigned this Sep 25, 2024
Copy link
Contributor

@alexandrius alexandrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Mb we should refactor to ts?

@headfire94 headfire94 changed the title feat: export all types feat: export all types and make them generic Sep 25, 2024
@headfire94
Copy link
Contributor Author

@alexandrius added generic types as well, found issues without them while testing in TS lib that we can't pass additional props to components not related to styles to use in styled.View((props) => props.unrelated ? {} : {} )

@headfire94
Copy link
Contributor Author

Mb we should refactor to ts?

Will be good, but don't wanna spend time on that atm

@headfire94 headfire94 merged commit af85c96 into ain/perf Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants