Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add missing types #17

Merged
merged 1 commit into from
Sep 25, 2024
Merged

feat: add missing types #17

merged 1 commit into from
Sep 25, 2024

Conversation

headfire94
Copy link
Contributor

extends, withChild, attrs, withComponent were missing. Also View, Text, Image and Touchable must return StyledComponentType not ComponentType

alexandrius
alexandrius approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@alexandrius alexandrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are great thanks. utACK

@headfire94 headfire94 merged commit 4fd9fde into ain/perf Sep 25, 2024
@alexandrius
Copy link
Contributor

should we change main repo to master instead of ain/perf?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrius alexandrius alexandrius approved these changes

@andrewtoth andrewtoth Awaiting requested review from andrewtoth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@headfire94 @alexandrius