-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: types #11
feat: types #11
Conversation
Why drop rollup? Shakl works in the DOM too this breaks it |
@sonaye Brought Ideally we should have 2 different packages. |
@sonaye How do you prefer to proceed?
works internally, VSCode ignores it. I think we better have 2 packages: We can leave with this approach too. Types work well |
@alexandrius prefer to not break things and keep one package, can this be merged as it's or it won't work? |
@sonaye now the change doesn't break anything apart false types on dom |
@alexandrius you can self merge and publish a new version |
Closes: https://app.asana.com/0/1202332025965022/1205700522198310
shakl
Image
as default export