Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: types #11

Merged
merged 6 commits into from
Oct 16, 2023
Merged

feat: types #11

merged 6 commits into from
Oct 16, 2023

Conversation

alexandrius
Copy link
Contributor

@alexandrius alexandrius commented Oct 12, 2023

Closes: https://app.asana.com/0/1202332025965022/1205700522198310

  • Adds types to shakl
  • Adds Image as default export
  • Types work with dynamic components too
  • Drops rollup
Screenshot 2023-10-12 at 8 17 33 PM Screenshot 2023-10-12 at 8 17 51 PM Screenshot 2023-10-12 at 8 18 16 PM

@sonaye
Copy link
Collaborator

sonaye commented Oct 12, 2023

Why drop rollup? Shakl works in the DOM too this breaks it

@alexandrius
Copy link
Contributor Author

@sonaye Brought rollup back.

Ideally we should have 2 different packages.

@alexandrius
Copy link
Contributor Author

alexandrius commented Oct 13, 2023

@sonaye How do you prefer to proceed?
While this:

"react-native": "lib/rn.js",

works internally, VSCode ignores it.

I think we better have 2 packages:
shakl-react-native and shakl

We can leave with this approach too. Types work well

@sonaye
Copy link
Collaborator

sonaye commented Oct 13, 2023

@alexandrius prefer to not break things and keep one package, can this be merged as it's or it won't work?

@alexandrius
Copy link
Contributor Author

@sonaye now the change doesn't break anything apart false types on dom

@sonaye
Copy link
Collaborator

sonaye commented Oct 13, 2023

@alexandrius you can self merge and publish a new version

@alexandrius alexandrius merged commit 6c51a71 into ain/perf Oct 16, 2023
@sonaye sonaye deleted the ap/types branch October 16, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants