Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: switch from TravisCI to Github Actions #19

Merged
merged 2 commits into from
Oct 27, 2022
Merged

chore: switch from TravisCI to Github Actions #19

merged 2 commits into from
Oct 27, 2022

Conversation

RyanZim
Copy link
Contributor

@RyanZim RyanZim commented Oct 26, 2022

No description provided.

@RyanZim RyanZim requested a review from mvayngrib October 26, 2022 20:01
mvayngrib
mvayngrib approved these changes Oct 26, 2022
View reviewed changes
Copy link

@mvayngrib mvayngrib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

checks look good. I guess we dropped old node versions?

@RyanZim
Copy link
Contributor Author

RyanZim commented Oct 26, 2022

No, didn't drop them since I'm not immediately planning a major release: https://github.com/ExodusMovement/redux-watch/pull/19/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR11

mvayngrib
mvayngrib approved these changes Oct 27, 2022
View reviewed changes
Copy link

@mvayngrib mvayngrib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

not sure how node 4 & 5 get tested now 🤔

@RyanZim
Copy link
Contributor Author

RyanZim commented Oct 27, 2022 •
edited
Loading

I'm operating on the assumption that if it works on recent stuff and also on 0.10, it'll work everywhere in between.

@RyanZim RyanZim merged commit ca9cc44 into master Oct 27, 2022
@RyanZim RyanZim deleted the ryan/ci branch October 27, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvayngrib mvayngrib mvayngrib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RyanZim @mvayngrib