fix: Wallet crashes on iOS when you switch portfolios #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andrejborstnik could someone with more obj-c expertise give this a look |
|
@ExodusMovement/appsec could you please review this PR |
mariosvlad
requested changes
Dec 16, 2024
ios/REANodesManager.m
Outdated
| @@ -277,7 +320,7 @@ - (void)performOperations | |||
|
|
|||
| if (canUpdateSynchronously) { | |||
| [strongSelf.uiManager runSyncUIUpdatesWithObserver:strongSelf]; | |||
There was a problem hiding this comment.
Suggested change
| [strongSelf.uiManager runSyncUIUpdatesWithObserver:strongSelf]; | |
| [strongSelf.uiManager runSyncUIUpdatesWithObserver:syncUpdateObserver]; |
this change was also in the patch, needed because of the removal of @interface REANodesManager () <RCTUIManagerObserver> I think
There was a problem hiding this comment.
thanks for the capture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applies fix from
react-native-reanimated: software-mansion#4403 to handle assertion error REANodesManager.m when receiving mounting block from the React's UI Manager.Test code and steps to reproduce
Checklist