Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop Node.js client, Mirror support, AddressBooks #39

Closed
wants to merge 1 commit into from

Conversation

ChALkeR
Copy link

@ChALkeR ChALkeR commented Dec 1, 2021

This removes a lot of hardcoded stuff which we apparently don't really need.

Drops Node.js client.

We can hopefully use RN client for testing, given globalThis.fetch = require('node-fetch').

Drops Mirror support

It was supported only in Node.js client and is unused.

Drops AddressBooks

Also looked unreachable (given that we don't use Node.js client).

@ChALkeR ChALkeR requested a review from feri42 December 1, 2021 23:49
@feri42
Copy link

feri42 commented Dec 2, 2021

I need the nodejs client for the account faucet back-end. But I can use the original @hashgraph/hedera-sdk there with some refactoring.

@ChALkeR ChALkeR force-pushed the exodus branch 4 times, most recently from 7e49f39 to 4fd68cc Compare December 14, 2021 01:32
@ChALkeR ChALkeR force-pushed the chalker/no-node branch 2 times, most recently from 7df0908 to 320465e Compare December 14, 2021 02:14
@ChALkeR ChALkeR marked this pull request as draft December 14, 2021 02:15
Copy link

@feri42 feri42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - under mild protest

@ChALkeR
Copy link
Author

ChALkeR commented Dec 15, 2021

Replaced by #57, #58, #59.

Node.js client is kept there.

@ChALkeR ChALkeR closed this Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants