Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: separate out and disable keychain integration tests #15

Merged
merged 4 commits into from
Jan 23, 2024

Conversation

mvayngrib
Copy link
Collaborator

@mvayngrib mvayngrib commented Jan 9, 2024

Summary

integration tests will be moved to the assets monorepo. For now, disabling here and removing relevant devDeps to decrease the load of open sourcing all dependencies in this repo

Test Plan

  • tests pass (wait for checks)
  • apply diff, run yarn && cd features/keychain && yarn todo:reenable:test:integration - tests pass
diff --git a/features/keychain/package.json b/features/keychain/package.json
index b0c1cae..d59faa5 100644
--- a/features/keychain/package.json
+++ b/features/keychain/package.json
@@ -45,6 +45,12 @@
     "p-defer": "^4.0.0"
   },
   "devDependencies": {
+    "@exodus/assets": "latest",
+    "@exodus/cardano-lib": "^2.0.3",
+    "@exodus/ethereum-lib": "^3.3.6",
+    "@exodus/solana-lib": "^1.3.11",
+    "@exodus/solana-meta": "^1.0.2",
+    "@exodus/storage-memory": "^2.1.1",
     "bip39": "2.6.0",
     "eslint": "^8.44.0",
     "events": "^3.3.0",

@mvayngrib mvayngrib self-assigned this Jan 9, 2024
@mvayngrib mvayngrib requested a review from 633kh4ck January 9, 2024 16:11
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
Copy link
Contributor

@diegomura diegomura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@mvayngrib mvayngrib mentioned this pull request Jan 9, 2024
Copy link
Contributor

@feri42 feri42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@mvayngrib mvayngrib force-pushed the mv/keychain-dev-deps branch from f273fa8 to dbbbe85 Compare January 23, 2024 21:30
@mvayngrib mvayngrib merged commit acd5eed into master Jan 23, 2024
2 of 7 checks passed
@mvayngrib mvayngrib deleted the mv/keychain-dev-deps branch January 23, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants