Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade winston from 3.2.1 to 3.3.4 #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Exnadella
Copy link
Owner

@Exnadella Exnadella commented Sep 5, 2024

User description

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the npm dependencies of this project.

Snyk changed the following file(s):

  • packages/project-config/package.json
  • packages/project-config/package-lock.json

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Prototype Pollution
SNYK-JS-ASYNC-2441827
  696  
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-COLORSTRING-1082939
  586  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Prototype Pollution
🦉 Regular Expression Denial of Service (ReDoS)


PR Type

enhancement, bug fix


Description

  • Upgraded the winston package from version ^3.0.0 to ^3.3.4 in package.json to address security vulnerabilities.
  • Updated package-lock.json to reflect the changes made in package.json.
  • This upgrade addresses vulnerabilities related to Prototype Pollution and Regular Expression Denial of Service (ReDoS).

Changes walkthrough 📝

Relevant files
Dependencies
package.json
Upgrade `winston` package to address vulnerabilities         

packages/project-config/package.json

  • Upgraded winston package from version ^3.0.0 to ^3.3.4.
+1/-1     
package-lock.json
Update package-lock.json for `winston` upgrade                     

packages/project-config/package-lock.json

  • Updated lock file to reflect the upgrade of winston to version 3.3.4.
  • +978/-991
    Additional files (token-limit)
    package-lock.json
    ...                                                                                                           

    packages/project-config/package-lock.json

    ...

    +978/-991

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    …ackage-lock.json to reduce vulnerabilities
    
    The following vulnerabilities are fixed with an upgrade:
    - https://snyk.io/vuln/SNYK-JS-ASYNC-2441827
    - https://snyk.io/vuln/SNYK-JS-COLORSTRING-1082939
    Copy link

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No key issues to review

    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Copy link

    codiumai-pr-agent-pro bot commented Sep 5, 2024

    CI Failure Feedback 🧐

    (Checks updated until commit 7b690a5)

    Action: test (ubuntu-latest)

    Failed stage: Run npm run bootstrap [❌]

    Failure summary:

    The action failed due to an error during the npm ci command execution:

  • Multiple deprecated packages were detected, which might not be directly related to the failure but
    indicate outdated dependencies.
  • The npm ci command exited with code 1 in the 'wct-mocha' package, indicating a failure during the
    installation process.
  • The exact cause of the npm ci failure is not specified in the log, but it suggests checking the npm
    debug log for more details.

  • Relevant error logs:
    1:  ##[group]Operating System
    2:  Ubuntu
    ...
    
    566:  npm WARN deprecated [email protected]: This module is no longer supported.
    567:  npm WARN deprecated [email protected]: This package is no longer supported.
    568:  npm WARN deprecated [email protected]: This package is no longer supported.
    569:  npm WARN deprecated [email protected]: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
    570:  npm WARN deprecated [email protected]: This package is no longer supported.
    571:  npm WARN deprecated @lerna/[email protected]: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
    572:  npm WARN deprecated @lerna/[email protected]: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
    573:  npm WARN deprecated @lerna/[email protected]: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
    574:  npm WARN deprecated @lerna/[email protected]: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
    ...
    
    748:  npm ERR! 
    749:  npm ERR! aliases: clean-install, ic, install-clean, isntall-clean
    750:  npm ERR! 
    751:  npm ERR! Run "npm help ci" for more info
    752:  npm ERR! A complete log of this run can be found in:
    753:  npm ERR!     /home/runner/.npm/_logs/2024-09-05T16_40_08_993Z-debug-0.log
    754:  lerna ERR! npm ci exited 1 in 'wct-mocha'
    755:  lerna WARN complete Waiting for 1 child process to exit. CTRL-C to exit immediately.
    756:  ##[error]Process completed with exit code 1.
    

    ✨ CI feedback usage guide:

    The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
    The tool analyzes the failed checks and provides several feedbacks:

    • Failed stage
    • Failed test name
    • Failure summary
    • Relevant error logs

    In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

    /checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"
    

    where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

    Configuration options

    • enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
    • excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
    • enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
    • persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
    • final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

    See more information about the checks tool in the docs.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants