Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix out of range access, minor performance improvement (0.27-maintenance backport) #1925

Merged
merged 5 commits into from
Sep 29, 2021

Conversation

kevinbackhouse
Copy link
Collaborator

This is a backport of #1918. Mergify didn't work.

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #1925 (b8daefe) into 0.27-maintenance (b669a9d) will not change coverage.
The diff coverage is 0.00%.

❗ Current head b8daefe differs from pull request most recent head d853f14. Consider uploading reports for the commit d853f14 to get more accurate results
Impacted file tree graph

@@                Coverage Diff                @@
##           0.27-maintenance    #1925   +/-   ##
=================================================
  Coverage             46.30%   46.30%           
=================================================
  Files                   146      146           
  Lines                 22948    22948           
  Branches              11781    11781           
=================================================
  Hits                  10626    10626           
  Misses                 6707     6707           
  Partials               5615     5615           
Impacted Files Coverage Δ
src/tags_int.cpp 54.54% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b669a9d...d853f14. Read the comment docs.

@kevinbackhouse
Copy link
Collaborator Author

I don't understand why the codecov check is failing. I am very sure that the new tests cover every branch of the new code.

Copy link
Collaborator

@clanmills clanmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinbackhouse As always, thank you for working on this.

Copy link
Collaborator

@clanmills clanmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinbackhouse As always, thank you for working on this.

@kevinbackhouse kevinbackhouse merged commit a8bd3a6 into Exiv2:0.27-maintenance Sep 29, 2021
@kevinbackhouse kevinbackhouse deleted the my_fix_01 branch September 29, 2021 21:37
@clanmills clanmills mentioned this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants