Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid reading 1 byte off the end when the string does not contain a '\0' byte (backport #1888) #1889

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 2, 2021

This is an automatic backport of pull request #1888 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

(cherry picked from commit 9c4f9c7)
…l?id=37889

Avoid reading 1 byte off the end when the string does not contain a '\0' byte.

(cherry picked from commit bd211a9)
@kevinbackhouse kevinbackhouse self-assigned this Sep 2, 2021
@kevinbackhouse kevinbackhouse added OSS-Fuzz Bug reported by https://google.github.io/oss-fuzz/ bug labels Sep 2, 2021
@kevinbackhouse kevinbackhouse added this to the v0.27.5 milestone Sep 2, 2021
@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #1889 (a95fe1f) into 0.27-maintenance (b9e35f6) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@                Coverage Diff                @@
##           0.27-maintenance    #1889   +/-   ##
=================================================
  Coverage             46.27%   46.28%           
=================================================
  Files                   146      146           
  Lines                 22950    22947    -3     
  Branches              11780    11780           
=================================================
- Hits                  10621    10620    -1     
+ Misses                 6713     6712    -1     
+ Partials               5616     5615    -1     
Impacted Files Coverage Δ
src/crwimage_int.cpp 48.21% <66.66%> (-0.09%) ⬇️
src/crwimage.cpp 32.92% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9e35f6...a95fe1f. Read the comment docs.

@kevinbackhouse kevinbackhouse mentioned this pull request Sep 3, 2021
@kevinbackhouse kevinbackhouse merged commit 4921385 into 0.27-maintenance Sep 5, 2021
@mergify mergify bot deleted the mergify/bp/0.27-maintenance/pr-1888 branch September 5, 2021 16:35
@clanmills clanmills mentioned this pull request Sep 8, 2021
@kevinbackhouse kevinbackhouse linked an issue Dec 21, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug OSS-Fuzz Bug reported by https://google.github.io/oss-fuzz/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Out-of-bounds read in CrwMap::decode0x080a
2 participants