Replace assertion with error message in TiffDirectory::writeDirEntry() #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinbackhouse
added
bug
forward-to-main
hassec
previously approved these changes
Aug 5, 2021
|
@kevinbackhouse it does look like some tests need adjusting for this change though |
kevinbackhouse
force-pushed
the
FixIssue1845
branch
from
fb5bf1b
to
634d319
Compare
MaheedharM
approved these changes
Aug 6, 2021
hassec
approved these changes
Aug 6, 2021
kevinbackhouse
added a commit
that referenced
this pull request
Aug 6, 2021
Replace assertion with error message in TiffDirectory::writeDirEntry() (backport #1846)
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1845
I think this assertion is checking a property that isn't enforced during parsing, so it is better to replace it with an error message.