Replace assertion with an error message #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinbackhouse
added
bug
forward-to-main
hassec
approved these changes
Aug 3, 2021
kevinbackhouse
added a commit
that referenced
this pull request
Aug 3, 2021
Replace assertion with an error message (backport #1834)
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1833
This assertion is checking a property that, as far as I can tell, isn't enforced anywhere. Nothing bad happens in a release build with assertions switched off, so I think the best solution is to replace the assertion with an error message.
As I mentioned in #1833, I am only able to reproduce this with the fuzzer, which means that the test that I have added isn't a proper regression test. So the main purpose of adding a test is to add the poc to our fuzzing corpus.