cmake: Fix include_directories for exiv2lib target#1306
Merged
piponazo merged 1 commit intoExiv2:masterfrom Sep 16, 2020
Merged
cmake: Fix include_directories for exiv2lib target#1306piponazo merged 1 commit intoExiv2:masterfrom
piponazo merged 1 commit intoExiv2:masterfrom
Conversation
The headers are installed to ${CMAKE_INSTALL_INCLUDEDIR} but the CMake config was hardcoded to include directory.
(cherry-picked from 306c8a6)
piponazo
approved these changes
Sep 16, 2020
Collaborator
piponazo
left a comment
piponazo
left a comment
There was a problem hiding this comment.
The change looks good to me, but for some reason I do not understand many of the CI checks did not run (and the Appveyor one failed) 😩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The headers are installed to ${CMAKE_INSTALL_INCLUDEDIR} but the CMake config was hardcoded to include directory.
(cherry-picked from 306c8a6 (#1294))