test: xud-simulation migration #852

moshababo · 2019-03-23T18:23:17Z

Closes #765.

This PR is migrating xud-simulation under xud/test/simulation.

I changed .travis to have language: go instead of language: node_js. Otherwise go1.7.4 is being shipped, which isn't sufficient for Go Modules.

The new .travis file is a bit messy now, combining 2 environments. Feel free to suggest improvements.

Also, please execute it on your local machine by running npm run test:sim (go1.11.x installation is required).

ghost

Successfully ran the test suites locally - good job 👍 . Didn't manage to go over the code in detail, but in general looks very nice - excited to have these run on every build and prevent bugs in the core functionality :).

test/simulation/README.md

ghost · 2019-03-24T16:26:25Z

test/simulation/README.md

+GO111MODULE=on go test -v
+````
+
+## Network Scenarios Tests


Really like how much initial coverage is included.

kilrau · 2019-03-25T19:24:02Z

You mentioned after merging this there will be some fixes necessary to xud/test/simulation. Can this be done before merging? @moshababo

moshababo · 2019-03-26T06:21:10Z

@kilrau i'm not sure which fixes are you referring to.
I left some TODOs in the code (mostly for better code maintenance), and we need to add more coverage, but besides that, this should be merged soon so any new PR which breaks the protocol can be detected.

sangaman · 2019-03-26T08:49:12Z

Would it be an option to manually install the specific go version we want via the travis script before runnings tests, instead of switching the language to go? My concern is not being able to test multiple version of nodejs or specify which ones to use, right now it looks like it's using version 8 only which is no longer "active." I guess it would make the test runtime longer though?

Edit: I do see that we are installing the stable version of node manually which I suppose is fine, but we do still lose the ability to test multiple node versions which seems more important than testing multiple go versions.

sangaman

Fantastic work. In trying to run this locally, I'm getting this error:

=== RUN   TestExchangeUnionDaemon
2019/03/26 09:29:33 installing dependencies...
--- FAIL: TestExchangeUnionDaemon (9.53s)
    xud_test.go:155: Error outside of test: *errors.errorString installation error: starting lnd clone...
        finished lnd clone
        starting lnd make...
         Compiling dependencies.
        dep ensure -v
        Makefile:116: recipe for target 'dep' failed
        unable to make lnd
        
        
        /home/mcnallydp_gmail_com/xud/test/simulation/xud_test.go:191 (0x9ea82c)
                TestExchangeUnionDaemon: ht.Fatalf("%v", err)
        /usr/local/go/src/testing/testing.go:827 (0x4f799f)
                tRunner: fn(t)
        /usr/local/go/src/runtime/asm_amd64.s:1333 (0x45d131)
                goexit: BYTE    $0x90   // NOP
FAIL

I've tried manually running go get -u github.com/golang/dep/cmd/dep but that doesn't seem to help. Any ideas?

sangaman · 2019-03-26T08:52:14Z

test/simulation/xudrpc/xudrpc.proto

@@ -0,0 +1,579 @@
+// Copyright 2018 The Exchange Union Developers


For this and the other .proto files, would it be possible to reference the existing files in the repository (outside the simulation folder)? My concern is that we'd have to manually change files in two places and that they could fall out of sync.

Yes, I wanted to do that after the migration and forgot. the gen_protos.sh will still need to be triggered after changes though.

sangaman · 2019-03-26T08:56:35Z

package.json

@@ -31,6 +31,7 @@
    "test:p2p": "mocha -r ts-node/register test/p2p/*",
    "test:p2p:watch": "mocha -r ts-node/register test/p2p/*  --watch --watch-extensions ts",
    "test:crypto": "mocha -r ts-node/register test/crypto/*",
+    "test:sim": "(cd test/simulation && GO111MODULE=on go test -v)",


Since this won't work on Windows, something that may be worth doing here is using a cross-os script that prints something like "simulation tests not supported on windows" for windows and uses this script for linux/mac.

test/simulation/LICENSE

sangaman · 2019-03-26T09:29:27Z

test/simulation/README.md

+Installation & Usage:
+
+```bash
+$ GO111MODULE=on go test -v


Does it make sense to change this to npm run test:sim?

I didn't do it so it will be treated as independent folder to be run directly. But since we want to create a dependency with the .proto files, I can that.

I fixed that, but didn't push yet because I wanted you to see the current travis failure status.

kilrau · 2019-03-26T13:32:19Z

@kilrau i'm not sure which fixes are you referring to.
I left some TODOs in the code (mostly for better code maintenance), and we need to add more coverage, but besides that, this should be merged soon so any new PR which breaks the protocol can be detected.

Misunderstanding. Just ignore what I said.

sangaman · 2019-03-28T02:17:23Z

FYI, I got past my error above (I think I needed to add to the go/bin folder to my path) but now I'm hitting this error when trying to run npm run test:sim

=== RUN   TestExchangeUnionDaemon
2019/03/28 02:12:31 installing dependencies...
2019/03/28 02:13:49 
starting lnd clone...
finished lnd clone
starting lnd make...
 Compiling dependencies.
dep ensure -v
 Building debug lnd and lncli.
go build -v -tags="dev" -o lnd-debug -ldflags "-X github.com/lightningnetwork/lnd/build.Commit=v0.4.2-beta-1255-ga62cd86a8bb9a993cc2ad14c8fcae20bc2e2f967" github.com/lightningnetwork/lnd
go build -v -tags="dev" -o lncli-debug -ldflags "-X github.com/lightningnetwork/lnd/build.Commit=v0.4.2-beta-1255-ga62cd86a8bb9a993cc2ad14c8fcae20bc2e2f967" github.com/lightningnetwork/lnd/cmd/lncli
finished lnd make
--- FAIL: TestExchangeUnionDaemon (154.73s)
    xud_test.go:232: ltcd: launching node...
    xud_test.go:244: ltcd: 200 blocks generated
    xud_test.go:270: lnd-ltc: launching network...
    xud_test.go:305: btcd: launching node...
    xud_test.go:320: btcd: 200 blocks generated
    xud_test.go:352: lnd-btc: launching network...
   xud_test.go:371: launching xud network...
    xud_test.go:155: Error outside of test: *errors.errorString cannot set up xud network: timeout waiting for TLS cert file to be created after 30 seconds
        /home/mcnallydp_gmail_com/xud/test/simulation/xud_test.go:373 (0x9eb9c8)
                TestExchangeUnionDaemon: ht.Fatalf("cannot set up xud network: %v", err)
        /usr/local/go/src/testing/testing.go:827 (0x4f799f)
                tRunner: fn(t)
        /usr/local/go/src/runtime/asm_amd64.s:1333 (0x45d131)
                goexit: BYTE    $0x90   // NOP
    xud_test.go:155: Error outside of test: *errors.errorString cannot tear down xud network harness: failed to kill process: os: process already finished
        /home/mcnallydp_gmail_com/xud/test/simulation/xud_test.go:365 (0x9eda09)
                TestExchangeUnionDaemon.func9: ht.Fatalf("cannot tear down xud network harness: %v", err)
        /usr/local/go/src/runtime/asm_amd64.s:522 (0x45b41b)
                call32: CALLFN(·call32, 32)
        /usr/local/go/src/runtime/panic.go:397 (0x42d23f)
                Goexit: reflectcall(nil, unsafe.Pointer(d.fn), deferArgs(d), uint32(d.siz), uint32(d.siz))
        /usr/local/go/src/testing/testing.go:590 (0x4f6a99)
                (*common).FailNow: runtime.Goexit()
        /usr/local/go/src/testing/testing.go:634 (0x4f6f93)
                (*common).Fatalf: c.FailNow()
        /home/mcnallydp_gmail_com/xud/test/simulation/xud_test.go:155 (0x9ea49c)
                (*harnessTest).Fatalf: h.t.Fatalf("Error outside of test: %v", stacktrace)
        /home/mcnallydp_gmail_com/xud/test/simulation/xud_test.go:373 (0x9eb9c8)
                TestExchangeUnionDaemon: ht.Fatalf("cannot set up xud network: %v", err)
        /usr/local/go/src/testing/testing.go:827 (0x4f799f)
                tRunner: fn(t)
        /usr/local/go/src/runtime/asm_amd64.s:1333 (0x45d131)
                goexit: BYTE    $0x90   // NOP
    xud_test.go:332: lnd-btc: network harness teared down
    xud_test.go:301: btcd: harness teared down
    xud_test.go:254: lnd-ltc: network harness teared down
    xud_test.go:228: ltcd: harness teared down
FAIL
exit status 1
FAIL    github.com/ExchangeUnion/xud-simulation 154.791s

moshababo · 2019-03-29T13:55:01Z

@sangaman you’re on Windows, right? if so, then there’s more work to do to make it compatible.

I think I needed to add to the go/bin folder to my path

Probably related to filesystem permissions. Feel free to edit install.sh to support this. Otherwise we can just wait for LND update, which will might solve this, because dep won’t be needed anymore (since it’s using Go Modules).

but now I'm hitting this error when trying to run npm run test:sim

TLS cert file isn't created. This is probably because xud process crash immediately after launch, due to failure in creating the datadir, port collision, etc. To check this, you can disable the xud cleanup (Config.go, XudCleanup), and then look at the logs.

If you're not on Windows, let me know.

kilrau · 2019-04-04T12:24:53Z

Can "not finding any routes" actually be a travis problem? Any ideas what else it could be? @moshababo @erkarl

ghost · 2019-04-04T16:29:57Z

@sangaman this is a longshot, but could it be a firewall rule blocking the execution? I ran the tests again without problems on a fresh local environment. I did, however, have to allow some new firewall rules.

moshababo · 2019-04-05T06:56:13Z

@sangaman in regards to your cloud instance run failure, it looks like a filesystem error, wheres lnd is failing to create its macaroon file. In this case, you won't see any of the log folders, because these are xud logs, which didn't even start. lnd's logs are not being written to files, but I can add a support for that.

Will try to investigate the "NoRouteFound" problem some more. Also, will see if manually installing go on travis won't cause issues.

moshababo · 2019-04-05T08:07:42Z

Good news - I found and fixed a problem which caused the NoRouteFound error.
@sangaman please review my latest commit ("fix maker getRoutes bug") before approving this PR, because it changes non-test xud code.

moshababo · 2019-04-05T13:16:16Z

Travis builds were fixed after moving back to language: node_js.
Sometimes one of the 2 builds is failing due to weird grpc error, but after restarting the build, it seems to always pass.

So the PR looks ready to me. @sangaman please try run it again on your environment, and if you still have issues, let's discuss and try to debug. I don't think it should block from merging.

sangaman

Awesome, again this is great work.

Do you know why the change to Swaps.ts was necessary? It looks to me like the code does the same thing (although I think it's better organized this way anyhow, since the block checking for the existence of routes didn't need to be in the try block).

sangaman · 2019-04-05T14:52:43Z

I agree this is ready to merge (as we've said we can deal with non-showstopper issues down the road), just needs to be squashed into 1 or 2 commits. If you can do that today @moshababo I'd say go for it, otherwise I will in the evening my time.

moshababo · 2019-04-06T16:42:21Z

@sangaman I did change the code structure a bit, but the needed change was to check lnd routes to the taker lnd pubkey, where previously it was:

deal.makerToTakerRoutes = await swapClient.getRoutes(takerAmount, deal.peerPubKey);

having deal.peerPubKey = peer.nodePubKey. This was probably a leftover from previous refactoring.

Thanks for the feedbacks, i'm merging.

moshababo added 14 commits March 23, 2019 15:39

Add xud-simulation repo under /test/simulation

fc18c14

travis: npm run test:sim

3b4c82f

travis

0f46cf5

fix(p2p): use forEach instead of an iterator with pb kvpArray

1897df8

travis

bed5cb4

travis

6c30263

travis

651c8f2

travis

7a314e2

travis

a31e48b

travis

2b5b98f

travis

d512205

travis

a0448df

travis

7074bac

travis

564dbd8

moshababo requested review from a user and sangaman March 23, 2019 18:23

ghost assigned moshababo Mar 23, 2019

ghost added the in progress label Mar 23, 2019

moshababo requested a review from reliveyy March 24, 2019 04:21

ghost reviewed Mar 24, 2019

View reviewed changes

README update

48023c0

sangaman reviewed Mar 26, 2019

View reviewed changes

moshababo added 2 commits March 29, 2019 17:06

Remove license

2cbf80e

Travis debug

086f94b

moshababo added 2 commits April 5, 2019 09:59

Merge branch 'master' into sim-travis

bb3111d

fix maker getRoutes bug

479affc

moshababo added 15 commits April 5, 2019 11:11

fix maker getRoutes bug - fix err string

23c24c2

accept swap error handling

6450e6d

travis nodejs

cc0fc84

travis nodejs

0b278dd

travis nodejs

f8325c3

travis

f9dc0ea

travis

e0d3873

travis

5a9cb18

travis debug

46b1196

travis debug

06b026f

travis debug

2d1d9cf

travis debug

d374a58

travis debug

73381ae

travis debug

db96b96

finalize travis

cafc768

sangaman approved these changes Apr 5, 2019

View reviewed changes

ghost approved these changes Apr 6, 2019

View reviewed changes

moshababo merged commit f5f1876 into master Apr 6, 2019

ghost removed the in progress label Apr 6, 2019

moshababo deleted the sim-travis branch April 6, 2019 16:43

sangaman mentioned this pull request Apr 9, 2019

fix: use integer satoshi quantities #869

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: xud-simulation migration #852

test: xud-simulation migration #852

moshababo commented Mar 23, 2019

ghost left a comment

ghost Mar 24, 2019

kilrau commented Mar 25, 2019

moshababo commented Mar 26, 2019

sangaman commented Mar 26, 2019 •

edited

Loading

sangaman left a comment

sangaman Mar 26, 2019

moshababo Mar 29, 2019

sangaman Mar 26, 2019

sangaman Mar 26, 2019

moshababo Mar 29, 2019

moshababo Mar 29, 2019

kilrau commented Mar 26, 2019

sangaman commented Mar 28, 2019

moshababo commented Mar 29, 2019

kilrau commented Apr 4, 2019

ghost commented Apr 4, 2019

moshababo commented Apr 5, 2019

moshababo commented Apr 5, 2019

moshababo commented Apr 5, 2019

sangaman left a comment

sangaman commented Apr 5, 2019

moshababo commented Apr 6, 2019

		@@ -0,0 +1,579 @@
		// Copyright 2018 The Exchange Union Developers

test: xud-simulation migration #852

test: xud-simulation migration #852

Conversation

moshababo commented Mar 23, 2019

ghost left a comment

Choose a reason for hiding this comment

ghost Mar 24, 2019

Choose a reason for hiding this comment

kilrau commented Mar 25, 2019

moshababo commented Mar 26, 2019

sangaman commented Mar 26, 2019 • edited Loading

sangaman left a comment

Choose a reason for hiding this comment

sangaman Mar 26, 2019

Choose a reason for hiding this comment

moshababo Mar 29, 2019

Choose a reason for hiding this comment

sangaman Mar 26, 2019

Choose a reason for hiding this comment

sangaman Mar 26, 2019

Choose a reason for hiding this comment

moshababo Mar 29, 2019

Choose a reason for hiding this comment

moshababo Mar 29, 2019

Choose a reason for hiding this comment

kilrau commented Mar 26, 2019

sangaman commented Mar 28, 2019

moshababo commented Mar 29, 2019

kilrau commented Apr 4, 2019

ghost commented Apr 4, 2019

moshababo commented Apr 5, 2019

moshababo commented Apr 5, 2019

moshababo commented Apr 5, 2019

sangaman left a comment

Choose a reason for hiding this comment

sangaman commented Apr 5, 2019

moshababo commented Apr 6, 2019

sangaman commented Mar 26, 2019 •

edited

Loading