[WIP]: feat(orderbook): verify channel balance before placing an order #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
|
Nevermind, in hindsight this was a bad idea. |
ghost
force-pushed
the
feat/sanity-checks-orderbook
branch
2 times, most recently
from
5193dc4 to
3beaf0f
Compare
ghost
mentioned this pull request
ghost
force-pushed
the
feat/sanity-checks-orderbook
branch
from
06588bb to
f2de89f
Compare
added 9 commits
March 20, 2019 00:00
This commit fixes a bug where the Raiden reconnect timer would not cleanup when triggering a graceful shutdown. In addition, reconnect timer cleanup has been moved into the `BaseClient`.
ghost
force-pushed
the
feat/sanity-checks-orderbook
branch
from
f2de89f to
84c7de2
Compare
|
Closing this as most of the functionality here has been split up into smaller (approved) PRs. Going to create a separate PR as for the final step - too check the available outbound balance before adding orders to the order book. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#675