Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(peer) removing banning logic #634

Merged
merged 4 commits into from
Nov 11, 2018
Merged

refactor(peer) removing banning logic #634

merged 4 commits into from
Nov 11, 2018

Conversation

ImmanuelSegol
Copy link
Contributor

@ImmanuelSegol ImmanuelSegol commented Nov 2, 2018

closes #566

@ghost ghost assigned ImmanuelSegol Nov 2, 2018
@ghost ghost added the in progress label Nov 2, 2018
Copy link
Collaborator

@sangaman sangaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, just have a few comments but this looks good.

lib/p2p/NodeList.ts Outdated Show resolved Hide resolved
lib/p2p/Peer.ts Outdated Show resolved Hide resolved
lib/p2p/Peer.ts Outdated Show resolved Hide resolved
lib/types/enums.ts Outdated Show resolved Hide resolved
lib/types/enums.ts Outdated Show resolved Hide resolved
@sangaman sangaman merged commit 8b1199f into master Nov 11, 2018
@sangaman sangaman deleted the refactor-peer-ban branch November 11, 2018 23:47
@ghost ghost removed the in progress label Nov 11, 2018
@sangaman sangaman added the p2p Peer to peer networking label Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2p Peer to peer networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor peer penalizing/banning logic
2 participants