-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rpc): GetMnemonic #2000
feat(rpc): GetMnemonic #2000
Conversation
utACK |
The output just looks like this currently, I'm open to suggestions on if we want to include any additional information or formatting.
|
Looking at the current cli commands I'd change to |
Here's a quick primer on the aezeed format we're using for our mnemonic, and why the mnemonic we get will be different from the original creation of the seed and different from each time we get the mnemonic at runtime. The deciphered aezeed data is a 1 byte payload, 2 byte birthday/timestamp, and 16 bytes of entropy. We store that to our node key file encrypted on the disk, so all this is preserved, but we don't store the enciphered seed anywhere. The mnemonic represents the 33 byte enciphered seed, which includes the deciphered key plus a salt and checksum. The salt is going to to change every time we encipher the deciphered seed to recreate the mnemonic. So we'll get a different mnemonic every time, which may appear unusual to people used to conventional bip39 mnemonic seeds, but it's in fact a feature and not a bug. |
Thanks for the explainer @sangaman , I'd say let's leave the behavior as is and as just discussed add a hint (at least on the cli) for the user to know that this mnemonic will be different every time but still always recovers the same funds. |
bf8b80f
to
c582e77
Compare
New output:
|
Can short from
->
Apart from that looking good. |
*You can leave the details about why the mnemonic changes as in-code comment for that sentence. |
This adds a new rpc call `GetMnemonic` that can be used to retrieve the master seed mnemonic for xud at runtime after an xud node has been created. Closes #1982.
c582e77
to
273dc5a
Compare
Done, kept the message in the shorter form you suggested but tweaked it just a bit more:
|
Please give this another spin @raladev |
This adds a new rpc call
GetMnemonic
that can be used to retrieve the master seed mnemonic for xud at runtime after an xud node has been created.Closes #1982.