Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove raiden support #1824

Merged
merged 1 commit into from
Aug 19, 2020
Merged

refactor: remove raiden support #1824

merged 1 commit into from
Aug 19, 2020

Conversation

sangaman
Copy link
Collaborator

@sangaman sangaman commented Aug 19, 2020 •
edited
Loading

Closes #1516.

BREAKING CHANGE: removes raiden support & p2p packet fields

@sangaman sangaman self-assigned this Aug 19, 2020
ghost
ghost reviewed Aug 19, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂 🥳 👍

lib/constants/enums.ts
@@ -1,7 +1,6 @@
/** An enumeration of payment channel network clients that support token swaps. */
export enum SwapClientType {
Lnd,
Raiden,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this breaks existing xud environments since in the database it's 0, 1, 2, and now 0, 1?

test/jest/__snapshots__/NodeKey.spec.ts.snap Outdated
@@ -1,3 +1,3 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`NodeKey it should derive a child seed from private key 1`] = `"crouch cause bicycle tomato choice city produce ocean canyon rare laugh sudden close angle cage item special jeans either heavy skill bracket lift butter"`;
exports[`NodeKey it should derive a child seed from private key 1`] = `"chat toward myself element estate miracle merit pudding next net process idle mobile hawk transfer chimney border gate patient artefact square strike worth already"`;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why this snapshot update is necessary? Maybe I'm missing something, but there are no changes to NodeKey.ts

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use the name of the swap client in the entropy used to generate the child seed, so it makes sense that this is changing because it's going from raiden to connext.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right. It's because the enum changed. Thanks for clearing this up.

@kilrau kilrau requested a review from raladev August 19, 2020 11:50
@kilrau
Copy link
Contributor

kilrau commented Aug 19, 2020

Let's leave this one open until @raladev is back for manual testing

@ghost ghost mentioned this pull request Aug 19, 2020
Merged
@ghost
Copy link

ghost commented Aug 19, 2020

One minor nit. I'm not sure if refactor: * commit messages show up in the release notes? Maybe we change it since it'll be a breaking change on the p2p layer (we removed the raidenAddress field).

@sangaman
Copy link
Collaborator Author

One minor nit. I'm not sure if refactor: * commit messages show up in the release notes? Maybe we change it since it'll be a breaking change on the p2p layer (we removed the raidenAddress field).

Good point, it should get the BREAKING CHANGE label (which will show up in release notes).

@sangaman sangaman added the breaking A breaking or non-backwards compatible change label Aug 19, 2020
@ghost
Copy link

ghost commented Aug 19, 2020

@sangaman could you please rebase this so that it's testable via xud-docker setup (the contract address for USDT changed and it will cause infinite requests to the faucet if running the old version).

@sangaman
refactor: remove raiden support
4a5e18f 
Closes #1516.

BREAKING CHANGE: removes raiden support & p2p packet fields
@sangaman
Copy link
Collaborator Author

@sangaman could you please rebase this so that it's testable via xud-docker setup (the contract address for USDT changed and it will cause infinite requests to the faucet if running the old version).

Done.

@sangaman sangaman requested a review from kilrau August 19, 2020 18:30
kilrau
kilrau approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@kilrau kilrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was a bit complicated to test because of the breaking changes on p2p layer, but looking good. Tested new environment and upgrading an existing environment with this branch.

@kilrau kilrau merged commit 9afe7d1 into master Aug 19, 2020
@ghost ghost deleted the remove-raiden branch August 20, 2020 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilrau kilrau kilrau approved these changes

@raladev raladev Awaiting requested review from raladev

Assignees

@sangaman sangaman

Labels
breaking A breaking or non-backwards compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Post-connext cleanup
2 participants
@sangaman @kilrau