fix(p2p): handle multiple socket errors #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the peer socket error handling to use `on` instead of `once` when listening for `error` events to ensure that an unexpected second `error` event doesn't crash xud after the `once` handler stops listening. Instead we use `on` to listen to all error events and then manually remove all listeners from the socket after it's destroyed. Fixes #1773
This adds a callback to handle errors from the `socket.write` function
when sending packets to peers. Previously we would not specify a
callback at all, and errors would only get handled by the generic
`socket.on('error')` event handler.
sangaman
added
bug
raladev
approved these changes
Aug 3, 2020
ghost
approved these changes
Aug 4, 2020
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1773
This changes the peer socket error handling to use
oninstead ofoncewhen listening forerrorevents to ensure that an unexpected seconderrorevent doesn't crash xud after theoncehandler stops listening. Instead we useonto listen to all error events and then manually remove all listeners from the socket after it's destroyed.This also adds a callback to handle errors from the
socket.writefunction when sending packets to peers. Previously we would not specify a callback at all, and errors would only get handled by the genericsocket.on('error')event handler.