Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update typescript #1404

Merged
merged 1 commit into from
Feb 24, 2020
Merged

chore: update typescript #1404

merged 1 commit into from
Feb 24, 2020

Conversation

sangaman
Copy link
Collaborator

@sangaman sangaman commented Feb 24, 2020

This updates to the latest typescript version. I am mainly interested in taking advantage of the new Optional Chaining feature to write more concise code when making nullish checks.

@sangaman sangaman added the build Related to build process and automation label Feb 24, 2020
@sangaman sangaman requested a review from a user February 24, 2020 01:22
@sangaman sangaman self-assigned this Feb 24, 2020
This updates to the latest typescript version. I am mainly interested
in taking advantage of the new [Optional Chaining](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#optional-chaining)
feature to write more concise code when making nullish checks.
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looking forward to having optional chaning in the codebase - nice syntastic sugar.

@sangaman sangaman merged commit d376e4c into master Feb 24, 2020
@sangaman sangaman deleted the typescript-update branch February 24, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to build process and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant