test: add test case for backup feature #1353
Conversation
There was a problem hiding this comment.
Tests are failing due to RangeError: Maximum call stack size exceeded while writing files and it's not clear to me what's causing it. It doesn't happen for me locally so it's not easy to pinpoint. If it's not apparent what's causing it for you either, I can help some more with debugging it.
| fs.rmdirSync(dir); | ||
| }; | ||
|
|
||
| const wait = (ms: number) => { |
There was a problem hiding this comment.
There's a utils setTimeoutPromise for this you can import and use in the same way instead of this function.
| ); | ||
|
|
||
| // Wait 100ms to make sure the file watcher handled the new file | ||
| await wait(100); |
There was a problem hiding this comment.
It would be nice here to be able to actually be notified when the new file update has been handled, instead of waiting a fixed amount of time. I figure the easiest way to do that would be to make the Backup class extend EventEmitter, then add an event for when a new backup is written and emit it after or at the end of the writeBackup call along with an identifier (either client or dbpath). Then you can listen for that here and elsewhere wait is being used.
|
Combining this PR with #1352 because I want to ensure this test case passes with the changes from that PR. |
Tests for #1032. Some dependencies might have to be updated to make Travis pass for this.