fix: show LND info while it is out of sync #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael1011
added
lightning
sangaman
requested changes
Oct 17, 2019
lib/lndclient/LndClient.ts
Outdated
| @@ -238,7 +236,10 @@ class LndClient extends SwapClient { | |||
| uris = getInfoResponse.getUrisList(); | |||
| version = getInfoResponse.getVersion(); | |||
| alias = getInfoResponse.getAlias(); | |||
| if (channels.active <= 0) { | |||
|
|
|||
| if (!this.isConnected()) { | |||
There was a problem hiding this comment.
I think it would make sense to add a new isOutOfSync() method for SwapClient and check that here, then throw a new error OUT_OF_SYNC instead of UNAVAILABLE. That way callers can tell whether lnd is actually unavailable/offline or if it's up but simply out of sync and not ready.
There was a problem hiding this comment.
Because of this.status in errors.UNAVAILABLE(this.currency, this.status).message the error message already shows that LND is out of sync.
I agree on isOutOfSync() but don't think that a new error is necessary because of the reason stated above.
There was a problem hiding this comment.
Good point, I overlooked that.
michael1011
force-pushed
the
lnd-info-while-syncing
branch
from
8529f34 to
485aa8f
Compare
sangaman
approved these changes
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1276