Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update NPM dependencies #1289

Merged
merged 1 commit into from
Oct 18, 2019
Merged

chore: update NPM dependencies #1289

merged 1 commit into from
Oct 18, 2019

Conversation

michael1011
Copy link
Contributor

Closes protocolbuffers/protobuf#930

This PR updates all NPM dependencies apart from sequelize (there are breaking changes; should be done in a separate PR).

After running ncu -u (a tool to update all NPM dependencies), I fixed some minor compilation errors and did some test swaps on simnet to make sure those dependency updates don't break anything.

@michael1011 michael1011 added the build Related to build process and automation label Oct 12, 2019
@michael1011 michael1011 requested review from a user, sangaman and kilrau October 12, 2019 09:14
@michael1011 michael1011 self-assigned this Oct 12, 2019
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot :).

Copy link
Collaborator

@sangaman sangaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See one concern below. Do we know which dependency is actually causing the deprecation warnings in #930?

package.json Outdated Show resolved Hide resolved
@michael1011
Copy link
Contributor Author

The deprecation warnings in protocolbuffers/protobuf#930 were related to not importing the crypto module of node correctly: nodejs/node#23203 (comment). This was fixed quite a while ago.

But @kilrau also mentioned in the issue that all of the dependencies should be updated too, which is what I have done in this PR.

@michael1011 michael1011 force-pushed the update-dependencies branch 2 times, most recently from 7acbcc1 to 96e0a48 Compare October 17, 2019 15:51
Copy link
Collaborator

@sangaman sangaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sehr gut!

@michael1011 michael1011 merged commit ddffc43 into master Oct 18, 2019
@michael1011 michael1011 deleted the update-dependencies branch October 18, 2019 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to build process and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants