chore: run jest script in jest dir #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Sep 24, 2019
michael1011
reviewed
Sep 24, 2019
|
Yeah it's intentional, I figured that the seedutil code is separate and mostly static such that we don't gain much from compiling and running it every build. Paricularly with the pending Raiden changes which makes the build take much longer. |
|
@sangaman I wouldn't feel to comfortable not running some tests at all in the CI. What about using a build matrix similar to what LND is doing? This would allow that the seedutil is compiled and tested in parallel to the normal CI script? (If we agree on setting it up it doesn't have to be implemented in this PR though) |
|
Hmm ok I will put it back in for now, I think longer term it's worth changing though. I'll look into a build matrix or another approach to split it off from our main suite of tests. |
sangaman
force-pushed
the
test/jest-script
branch
from
3c9c484 to
110fe48
Compare
sangaman
force-pushed
the
test/jest-script
branch
2 times, most recently
from
40a94b4 to
cb1c1c7
Compare
This prevents the jest script from running any nested versions of xud such as those that may be installed in the simulation test temp dir. It also separates the seedutil tests from running with the rest of the jest tests.
sangaman
force-pushed
the
test/jest-script
branch
from
cb1c1c7 to
1179fbc
Compare
michael1011
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the jest script from running any nested versions of xud such as those that may be installed in the simulation test temp dir.
It also separates the seedutil tests from running with the rest of the jest tests
and removes its dependencies from the travis config.