Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rpc): GetBalance enhancements #1197

Merged
merged 2 commits into from
Oct 17, 2019
Merged

feat(rpc): GetBalance enhancements #1197

merged 2 commits into from
Oct 17, 2019

Conversation

krrprr
Copy link
Collaborator

@krrprr krrprr commented Aug 31, 2019

Next step after the PR #1180 in closing the issue #1062

Changes:
renamed Ticker -> Currency
added wallet balance information (LND only)

@krrprr krrprr force-pushed the feat/balance-command-improvements branch from 855e71d to c650a9b Compare September 1, 2019 08:22
@kilrau kilrau requested review from sangaman and a user September 2, 2019 09:01
@krrprr krrprr mentioned this pull request Sep 10, 2019
Merged
@sangaman
Copy link
Collaborator

Looks like this needs to be rebased (the first commit is already in master), could you do that to make the review a little easier? Thanks.

@krrprr krrprr force-pushed the feat/balance-command-improvements branch from c650a9b to bc77611 Compare September 11, 2019 20:26
@krrprr
Copy link
Collaborator Author

krrprr commented Sep 11, 2019

Rebased and implemented the changes discussed in #1062.

Along the way my linter fixed some whitespace issues, so a bit more lines than expected are involved.

@krrprr krrprr force-pushed the feat/balance-command-improvements branch from c419099 to f4c0515 Compare September 24, 2019 09:27
@krrprr
Copy link
Collaborator Author

krrprr commented Oct 9, 2019

Any updates? Is this feature (and other calls described in #1062) still something that is needed?

@kilrau
Copy link
Contributor

kilrau commented Oct 9, 2019

Any updates? Is this feature (and other calls described in #1062) still something that is needed?

Yes, of course. I think you deserve a review by @sangaman

sangaman
sangaman approved these changes Oct 17, 2019
View reviewed changes
Copy link
Collaborator

@sangaman sangaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in reviewing. This looks really good and should be a nice enhancement, plus I like the whitespace style cleanup. I will squash merge because the first commit looks like it's obsolete. Thank you!

@sangaman sangaman added enhancement New feature or request grpc gRPC API labels Oct 17, 2019
@sangaman sangaman changed the title feat(rpc): Add Wallet Balance and rename Ticker to Currency in balance command output feat(rpc): GetBalance enhancements Oct 17, 2019
@sangaman sangaman merged commit fc984cb into ExchangeUnion:master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sangaman sangaman sangaman approved these changes

Assignees

@krrprr krrprr

Labels
enhancement New feature or request grpc gRPC API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krrprr @sangaman @kilrau