refactor(lnd): use SendPayment instead of SendToRoute #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
needs your review @sangaman |
sangaman
reviewed
Aug 5, 2019
ghost
force-pushed
the
refactor/lnd-use-sendpayment
branch
from
356c6dd to
5ab5523
Compare
ghost
force-pushed
the
refactor/lnd-use-sendpayment
branch
from
5ab5523 to
c2aa68c
Compare
|
@sangaman thanks for the review - feedback applied. |
sangaman
approved these changes
Aug 6, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we refactor the logic of
LndClient.sendPaymentto useSendPaymentinstead ofSendToRoute.The maximum length/duration of maker's payment is enforced by specifying the
cltvLimit.