Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simnet - can't take order #978

Closed
offerm opened this issue May 24, 2019 · 0 comments · Fixed by #985
Closed

simnet - can't take order #978

offerm opened this issue May 24, 2019 · 0 comments · Fixed by #985
Assignees
@sangaman
Labels
critical bug P1 top priority simnet
Milestone
1.0.0-beta

Comments

@offerm
Copy link
Contributor

offerm commented May 24, 2019

Can't take existing order.

ud@xud-test-2:~$ xucli listorders
Trading pair: LTC/BTC
┌────────────────────────────────────────────────────┬────────────────────────────────────────────────────┐
│ Buy                                                │ Sell                                               │
├───────────────────┬───────────────────┬────────────┼───────────────────┬───────────────────┬────────────┤
│ Quantity          │ Price             │ Own Order  │ Quantity          │ Price             │ Own Order  │
├───────────────────┼───────────────────┼────────────┼───────────────────┼───────────────────┼────────────┤
│ 3.50000000        │ 0.0077            │            │ 2.50000000        │ 0.0079            │            │
├───────────────────┼───────────────────┼────────────┼───────────────────┼───────────────────┼────────────┤
│ 15.50000000       │ 0.0076            │            │ 13.00000000       │ 0.008             │            │
├───────────────────┼───────────────────┼────────────┼───────────────────┼───────────────────┼────────────┤
│ 18.00000000       │ 0.0075            │            │ 15.60000000       │ 0.0081            │            │
├───────────────────┼───────────────────┼────────────┼───────────────────┼───────────────────┼────────────┤
│ 21.25000000       │ 0.0074            │            │ 18.10000000       │ 0.0082            │            │
├───────────────────┼───────────────────┼────────────┼───────────────────┼───────────────────┼────────────┤
│ 24.00000000       │ 0.0073            │            │ 22.30000000       │ 0.0083            │            │
└───────────────────┴───────────────────┴────────────┴───────────────────┴───────────────────┴────────────┘
Trading pair: WETH/BTC
┌────────────────────────────────────────────────────┬────────────────────────────────────────────────────┐
│ Buy                                                │ Sell                                               │
├───────────────────┬───────────────────┬────────────┼───────────────────┬───────────────────┬────────────┤
│ Quantity          │ Price             │ Own Order  │ Quantity          │ Price             │ Own Order  │
└───────────────────┴───────────────────┴────────────┴───────────────────┴───────────────────┴────────────┘
xud@xud-test-2:~$ xucli buy 1 LTC/BTC marker
price must be numeric for limit orders or "mkt"/"market" for market orders
xud@xud-test-2:~$ xucli buy 1 LTC/BTC market
Error: 2 UNKNOWN: BTC outbound balance of 2499981936 is not sufficient for order amount of Infinity
xud@xud-test-2:~$ xud-log
xud@xud-test-2:~$

log has this:

24/05/2019 11:31:37.700 [RPC] debug: received call /xudrpc.Xud/PlaceOrderSync
24/05/2019 11:31:37.704 [RPC] error: BTC outbound balance of 2499981936 is not sufficient for order amount of Infinity
@offerm offerm assigned ghost and sangaman May 24, 2019
@kilrau kilrau added critical bug P1 top priority labels May 24, 2019
@kilrau kilrau added this to the 1.0.0 milestone May 24, 2019
@kilrau kilrau added the simnet label May 24, 2019
sangaman added a commit that referenced this issue May 26, 2019
@sangaman
fix: calculate swap amount for market orders
f668ced 
This fixes a bug where the calculated swap amount for a market buy order could
be infinity. This could cause the sanity capacity check to fail when checking
a market order. Market buy orders internally have a positive infinity price
value for matching logic purposes, but the final price for market orders is
not known upon first placing them.

Fixes #978.
@sangaman sangaman mentioned this issue May 26, 2019
Merged
sangaman added a commit that referenced this issue May 26, 2019
@sangaman
fix: calculate swap amount for market orders
13283cf 
This fixes a bug where the calculated swap amount for a market buy order could
be infinity. This could cause the sanity capacity check to fail when checking
a market order. Market buy orders internally have a positive infinity price
value for matching logic purposes, but the final price for market orders is
not known upon first placing them.

Fixes #978.
sangaman added a commit that referenced this issue May 28, 2019
@sangaman
fix: calculate swap amount for market orders
2399549 
This fixes a bug where the calculated swap amount for a market buy order could
be infinity. This could cause the sanity capacity check to fail when checking
a market order. Market buy orders internally have a positive infinity price
value for matching logic purposes, but the final price for market orders is
not known upon first placing them.

Fixes #978.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangaman sangaman

Labels
critical bug P1 top priority simnet
Projects
None yet
Milestone
1.0.0-beta
Development

Successfully merging a pull request may close this issue.

fix: calculate swap amount for market orders ExchangeUnion/xud
3 participants
@sangaman @offerm @kilrau