feat: discover nodes from a specific peer #920
Conversation
ghost
assigned 
lib/service/Service.ts
Outdated
| @@ -374,6 +377,14 @@ class Service extends EventEmitter { | |||
| return this.orderBook.removePair(pairId); | |||
| } | |||
|
|
|||
| /** Removes a trading pair. */ | |||
There was a problem hiding this comment.
Comment doesn't match up with the method.
proto/xudrpc.proto
Outdated
| string peer_pub_key = 1 [json_name = "peer_pub_key"]; | ||
| } | ||
| message DiscoverNodesResponse { | ||
| repeated NodeConnectionInfo nodes = 1; |
There was a problem hiding this comment.
Conceptually I'm wondering whether we want to actually return all the connection info we get from the peer. I am not sure whether that would be useful.
I'm thinking this call would be used to tell xud to find new peers, but the caller can't actually act on the nodepubkeys and all the addresses we discover, that's all handled internally. Instead we could just return the number of nodes that we discovered, or maybe just a list of pub keys (which can then be used to call getnodeinfo if we want more details). Thoughts @kilrau?
There was a problem hiding this comment.
I think "Discovered X new nodes" as response would be good. If the delta of "new nodes" is hard to calculate just go with "Discovered X nodes".
There was a problem hiding this comment.
The first option would require some infra work, so I went for the latter, since the use-case is quite limited.
Discover nodes from a specific peer, apply new connections, and return the list to the client.