Skip to content

Commit dcd5744

Browse files
committed
Return num of nodes instead of the nodes list connection info
1 parent d22b758 commit dcd5744

File tree

9 files changed

+31
-558
lines changed

9 files changed

+31
-558
lines changed

Diff for: docs/api.md

+1-35
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: lib/grpc/GrpcService.ts

+3-12
Original file line numberDiff line numberDiff line change
@@ -568,19 +568,10 @@ class GrpcService {
568568
*/
569569
public discoverNodes: grpc.handleUnaryCall<xudrpc.DiscoverNodesRequest, xudrpc.DiscoverNodesResponse> = async (call, callback) => {
570570
try {
571-
const nodes = await this.service.discoverNodes(call.request.toObject());
571+
const numNodes = await this.service.discoverNodes(call.request.toObject());
572+
572573
const response = new xudrpc.DiscoverNodesResponse();
573-
response.setNodesList(nodes.map((node) => {
574-
const grpcNode = new xudrpc.NodeConnectionInfo();
575-
grpcNode.setNodepubkey(node.nodePubKey);
576-
grpcNode.setAddressesList(node.addresses.map((address) => {
577-
const grpcAddress = new xudrpc.Address();
578-
grpcAddress.setHost(address.host);
579-
grpcAddress.setPort(address.port);
580-
return grpcAddress;
581-
}));
582-
return grpcNode;
583-
}));
574+
response.setNumNodes(numNodes);
584575

585576
callback(null, response);
586577
} catch (err) {

Diff for: lib/p2p/Peer.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -809,10 +809,10 @@ class Peer extends EventEmitter {
809809
return packet;
810810
}
811811

812-
public discoverNodes = async (): Promise<NodeConnectionInfo[]> => {
812+
public discoverNodes = async (): Promise<number> => {
813813
const packet = await this.sendGetNodes();
814814
const res = await this.wait(packet.header.id, packet.responseType);
815-
return res.body;
815+
return res.body.length;
816816
}
817817

818818
private sendPong = async (pingId: string): Promise<void> => {

Diff for: lib/p2p/Pool.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -502,7 +502,7 @@ class Pool extends EventEmitter {
502502
}
503503
}
504504

505-
public discoverNodes = async (peerPubKey: string): Promise<NodeConnectionInfo[]> => {
505+
public discoverNodes = async (peerPubKey: string): Promise<number> => {
506506
const peer = this.peers.get(peerPubKey);
507507
if (!peer) {
508508
throw errors.NOT_CONNECTED(peerPubKey);

Diff for: lib/proto/xudrpc.swagger.json

+3-31
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: lib/proto/xudrpc_pb.d.ts

+3-57
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)