Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove order is not being send to peers #767

Closed
offerm opened this issue Dec 24, 2018 · 3 comments · Fixed by #769
Closed

remove order is not being send to peers #767

offerm opened this issue Dec 24, 2018 · 3 comments · Fixed by #769
Assignees
@sangaman @moshababo
Labels
critical bug

Comments

@offerm
Copy link
Contributor

offerm commented Dec 24, 2018

My node (A) is connected to xud1,2,3.

listorders shows 2 x sell [email protected] (one order from xud1 and one order with xud2).

Using CLI:

xucli buy 2.5 LTC/BTC 0.0079

I swap with one of the nodes (xud1 in this case):

swapped 2.5 LTC with peer order 29dff850-07c0-11e9-a5e9-eba6222927d0

Post swap the sell order is replaced by the bot on xud1 and my node shows again 2 sell orders.

checking xucli getorders on xud3 shows 3 x sell [email protected] (one from xud3 and TWO from xud1).

The log does not show any remove order from xud1.

Very easy to reproduce.
@sangaman
Copy link
Collaborator

Looks like this is a similar bug/cause as #758, where superfluous fields are being hashed by the sender for the Order Invalidation packet and then failing validation on the receiver's end, thus the orders are not being invalidated by the receiver.

sangaman added a commit that referenced this issue Dec 25, 2018
@sangaman
fix(p2p): hash order invalidations correctly
d876e8b 
This fixes a bug where the hash calculated for outgoing order
invalidation packets wouldn't match the calculated hash for the packet
received by the peer due to the order objects being hashed having
extraneous properties that are not transmitted to the peer. This would
cause the order invalidations to be ignored by the receiver.

Fixes #767.
@sangaman sangaman mentioned this issue Dec 25, 2018
Merged
@ghost ghost added the in progress label Dec 25, 2018
@ghost ghost removed the in progress label Dec 25, 2018
@offerm
Copy link
Contributor Author

offerm commented Dec 26, 2018 •
edited
Loading

@sangaman Not solved.
Now, not only that the executed order is not being removed from peers the counter order is also added with a price of zero.

screen shot 2018-12-26 at 8 14 40

@offerm offerm reopened this Dec 26, 2018
@moshababo moshababo mentioned this issue Dec 26, 2018
Merged
@sangaman
Copy link
Collaborator

Looks like this is the key change that needed to happen in addition to my fix above, OrderInvalidationPackets were being converted into the wrong type of packet. 27e289b

Thanks offer for finding this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangaman sangaman

@moshababo moshababo

Labels
critical bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(p2p): hash order invalidations correctly ExchangeUnion/xud
3 participants
@sangaman @offerm @moshababo