Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExecuteSwapRequest improvements #734

Closed
kilrau opened this issue Dec 6, 2018 · 4 comments
Closed

ExecuteSwapRequest improvements #734

kilrau opened this issue Dec 6, 2018 · 4 comments
Assignees
@ImmanuelSegol
Labels
enhancement New feature or request grpc gRPC API P2 mid priority
Milestone
1.0.0-alpha.7

Comments

@kilrau
Copy link
Contributor

kilrau commented Dec 6, 2018

add result: completed / failed. This won't necessarily be used programmatically in the end, but makes the situation much clearer for engineers integrating & testing xud. Feedback from our test integration.

result: "completed"
order_id: "631145c0-f901-11e8-b518-5fd626b71b77"
pair_id: "LTC/BTC"
quantity: 0.001
r_hash: "aad8fae44138922fc52b1fca949c7f75294fa5f8345418634d23ba4d961b5b9f"
amount_received: 100000
amount_sent: 110000
peer_pub_key: "03fd337659e99e628d0487e4f87acf93e353db06f754dccc402f2de1b857a319d0"
currency_received: "LTC"
currency_sent: "BTC"
@kilrau kilrau added enhancement New feature or request grpc gRPC API P2 mid priority labels Dec 6, 2018
@kilrau kilrau added this to the 1.0.0-alpha.7 milestone Dec 6, 2018
@ImmanuelSegol ImmanuelSegol self-assigned this Dec 29, 2018
@kilrau kilrau modified the milestones: 1.0.0-alpha.7, 1.0.0-alpha.8 Jan 2, 2019
@ImmanuelSegol
Copy link
Contributor

@kilrau Did you mean I should add this to the SwapResult to indicate if the swap was successful ?

@kilrau
Copy link
Contributor Author

kilrau commented Jan 13, 2019

yep

@ImmanuelSegol ImmanuelSegol mentioned this issue Jan 19, 2019
Closed
@ghost ghost added the in progress label Jan 19, 2019
@sangaman
Copy link
Collaborator

I think that this will be effectively resolved by #787, which distinguishes between swap successes and failures by naming the fields SwapSuccess or SwapSuccesses and SwapFailure.

@sangaman sangaman mentioned this issue Jan 22, 2019
Merged
sangaman added a commit that referenced this issue Jan 22, 2019
@sangaman
feat(rpc): failed swaps for PlaceOrder
e23f837 
This adds a `SwapFailure` message type to the asynchronous `PlaceOrder`
rpc call. It is used to notify the caller in real time when a swap fails
for a given order. This also renames `SwapResult` to `SwapSuccess` to
clearly distinguish it from the unsuccessful `SwapFailure`.

Closes #609. Closes #734.
@kilrau
Copy link
Contributor Author

kilrau commented Jan 22, 2019

Ok, good to close this one then. Naturally you'll get rewarded for your work nevertheless @ImmanuelSegol

sangaman added a commit that referenced this issue Jan 23, 2019
@sangaman
feat(rpc): failed swaps for PlaceOrder
6c9c2a6 
This adds a `SwapFailure` message type to the asynchronous `PlaceOrder`
rpc call. It is used to notify the caller in real time when a swap fails
for a given order. This also renames `SwapResult` to `SwapSuccess` to
clearly distinguish it from the unsuccessful `SwapFailure`.

Closes #609. Closes #734.
@ghost ghost removed the in progress label Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ImmanuelSegol ImmanuelSegol

Labels
enhancement New feature or request grpc gRPC API P2 mid priority
Projects
None yet
Milestone
1.0.0-alpha.7
Development

Successfully merging a pull request may close this issue.

feat: swapResult now has result status ExchangeUnion/xud
3 participants
@sangaman @ImmanuelSegol @kilrau